Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Ovidiu-Adrian Vancea <ovidiu.vancea@ni.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2 0/3] ipk/deb/rpm: add kernel version to its dependencies
Date: Wed, 08 Jun 2016 17:59:30 +0100	[thread overview]
Message-ID: <1465405170.13979.111.camel@linuxfoundation.org> (raw)
In-Reply-To: <1465402114-1588-1-git-send-email-ovidiu.vancea@ni.com>

On Wed, 2016-06-08 at 19:08 +0300, Ovidiu-Adrian Vancea wrote:
> Updating the kernel (for all package managers) does not update the
> dependencies
> (eg. modules) because there is no possibility to do version
> enforcement in the
> OE recipe. Upon rebooting, the older version modules do not load and
> can leave
> hardware in a non-functioning state (if their drivers are not built
> into the
> kernel).
> 
> Use the Version field from the kernel package on its rdepends,
> rrecommends, and
> rsuggests fields’ version. This makes the packages on which the
> kernel depends
> to be the same version as the kernel. Version field contains package
> build
> number (including git hash) and package revision, thus restricting
> the kernel
> and modules to always be built together.
> 
> The current and default behavior will not change unless the variable 
> "VERSION_KERNEL_MODULES = 1" is defined in the kernel recipe.
> 
> Ovidiu-Adrian Vancea (3):
>   package_ipk.bbclass: add kernel version to its dependencies
>   package_deb.bbclass: add kernel version to its dependencies
>   package_rpm.bbclass: add kernel version to its dependencies

Why are you doing this at package_write_XXX? These tasks are there
specifically to write out the packages. With your changes the data
written to the packages would be different to that written out to
packagedata for example. We shouldn't encourage different package
metadata in different places.

I think this needs to happen somewhere at do_package time, probably
from a hook in module.bbclass?

Sorry if I wasn't clear about this last time.

Cheers,

Richard






  parent reply	other threads:[~2016-06-08 16:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08 16:08 [PATCH v2 0/3] ipk/deb/rpm: add kernel version to its dependencies Ovidiu-Adrian Vancea
2016-06-08 16:08 ` [PATCH v2 1/3] package_ipk.bbclass: " Ovidiu-Adrian Vancea
2016-06-08 16:08 ` [PATCH v2 2/3] package_deb.bbclass: " Ovidiu-Adrian Vancea
2016-06-08 16:08 ` [PATCH v2 3/3] package_rpm.bbclass: " Ovidiu-Adrian Vancea
2016-06-08 16:59 ` Richard Purdie [this message]
2016-06-09 14:47   ` [PATCH v2 0/3] ipk/deb/rpm: " Ovidiu-Adrian Vancea
2016-06-09 15:23     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465405170.13979.111.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ovidiu.vancea@ni.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox