From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Maxin B. John" <maxin.john@intel.com>,
openembedded-core@lists.openembedded.org
Cc: "Lock, Joshua" <joshua.g.lock@intel.com>,
"Bartosh, Eduard" <eduard.bartosh@intel.com>
Subject: Re: [PATCH] depexp.py: port to gtk+3
Date: Fri, 17 Jun 2016 17:31:16 +0100 [thread overview]
Message-ID: <1466181076.25557.20.camel@linuxfoundation.org> (raw)
In-Reply-To: <1466180018.25557.18.camel@linuxfoundation.org>
On Fri, 2016-06-17 at 17:13 +0100, Richard Purdie wrote:
> On Fri, 2016-06-17 at 17:19 +0300, Maxin B. John wrote:
> > Update depexp.py to support gtk+3
> >
> > Signed-off-by: Maxin B. John <maxin.john@intel.com>
> > ---
> > bitbake/lib/bb/ui/depexp.py | 127 ++++++++++++++++++++------------
> > --
> > ----------
> > 1 file changed, 58 insertions(+), 69 deletions(-)
> >
> > diff --git a/bitbake/lib/bb/ui/depexp.py
> > b/bitbake/lib/bb/ui/depexp.py
> > index 240aafc..8f603dd 100644
> > --- a/bitbake/lib/bb/ui/depexp.py
> > +++ b/bitbake/lib/bb/ui/depexp.py
> > @@ -18,14 +18,15 @@
> > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>
> Thanks for this, it certainly improves something which is currently
> much more broken. I've queued in master-next. Note that this really
> should go to the bitbake list in future.
>
> I also am a bit worried about the time.sleep(), am seeing if we can
> figure out how to avoid that before it merges...
Looks like its the gtk.init_check() in the bitbake thread before we
setup a separate gtk thread. The check needs to move to the other
thread with appropriate error handling, then we don't need the sleep.
The bitbake main thread needs to likely wait on the gtk init having
finished too.
Cheers,
Richard
prev parent reply other threads:[~2016-06-17 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 14:19 [PATCH] depexp.py: port to gtk+3 Maxin B. John
2016-06-17 16:13 ` Richard Purdie
2016-06-17 16:31 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466181076.25557.20.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=eduard.bartosh@intel.com \
--cc=joshua.g.lock@intel.com \
--cc=maxin.john@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox