Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Li Zhou <li.zhou@windriver.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] python3: correct the multilib support patch
Date: Wed, 29 Jun 2016 07:33:07 +0100	[thread overview]
Message-ID: <1467181987.8590.105.camel@linuxfoundation.org> (raw)
In-Reply-To: <20160629031255.3551-1-li.zhou@windriver.com>

On Wed, 2016-06-29 at 11:12 +0800, Li Zhou wrote:
> When python3 rebased its multilib patch, the hard coded "lib" path
> isn't really changed because of the rebasing's error, and cause
> phthon3's failure when running on 64bit platforms as below:
> Could not find platform independent libraries <prefix>
> Could not find platform dependent libraries <exec_prefix>
> Consider setting $PYTHONHOME to <prefix>[:<exec_prefix>]
> Fatal Python error: Py_Initialize: Unable to get the locale encoding
> ImportError: No module named 'encodings'
> 
> Here correct the rebasing error and solve this issue.
> 
> Signed-off-by: Li Zhou <li.zhou@windriver.com>
> ---
>  ...ython3-correct-the-multilib-support-patch.patch | 47
> ++++++++++++++++++++++
>  meta/recipes-devtools/python/python3_3.5.1.bb      |  1 +
>  2 files changed, 48 insertions(+)
>  create mode 100644 meta/recipes-devtools/python/python3/0001-python3
> -correct-the-multilib-support-patch.patch


Don't we want to correct the "bad" patch rather than adding an
additional patch? Or did I misunderstand the problem?

Also, are there some automated tests we should be adding to catch this
kind of problem? I'm a little worried none of our testing caught this.

Cheers,

Richard


  reply	other threads:[~2016-06-29  6:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29  3:12 [PATCH] python3: correct the multilib support patch Li Zhou
2016-06-29  6:33 ` Richard Purdie [this message]
2016-06-29 15:44   ` Randle, William C
2016-06-29 22:47     ` Dan McGregor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467181987.8590.105.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=li.zhou@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox