public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "André Draszik" <git@andred.net>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] image.bbclass: do not check size of the debugfs image
Date: Tue, 13 Sep 2016 08:44:40 +0100	[thread overview]
Message-ID: <1473752680.5279.3.camel@andred.net> (raw)
In-Reply-To: <CAJTo0LYGsh5fwJhsf57OcSxnRWxC2nXEM=dUbO+SeQKvnwos7A@mail.gmail.com>

Somebody did mention last week (Monday?) on IRC that mails are not arriving.
In the mailman web interface they aren't missing though (which is what I
sometimes use to check)... Strange

Andre'


On Mo, 2016-09-12 at 16:36 +0100, Burton, Ross wrote:
> Well there must have been some list/gmail snafu, as I definitely don't
> have
> this patch locally but patchwork has it.  I wonder what else I'm
> missing...
> 
> Ross
> 
> On 12 September 2016 at 16:26, André Draszik <git@andred.net> wrote:
> 
> > 
> > ping
> > 
> > On Mo, 2016-09-05 at 09:34 +0100, André Draszik wrote:
> > > 
> > > The debugfs is supposed to be used in addition to the
> > > normal image for debugging purposes, it doesn't make
> > > sense to artificially limit its maximum size.
> > > 
> > > Signed-off-by: André Draszik <git@andred.net>
> > > ---
> > >  meta/classes/image.bbclass | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > > 
> > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> > > index 07bd2d6..cb7d06d 100644
> > > --- a/meta/classes/image.bbclass
> > > +++ b/meta/classes/image.bbclass
> > > @@ -538,6 +538,12 @@ def get_rootfs_size(d):
> > >      base_size += rootfs_alignment - 1
> > >      base_size -= base_size % rootfs_alignment
> > > 
> > > +    # Do not check image size of the debugfs image. This is not
> > > supposed
> > > +    # to be deployed, etc. so it doesn't make sense to limit the size
> > > +    # of the debug.
> > > +    if (d.getVar('IMAGE_BUILDING_DEBUGFS', True) or "") == "true":
> > > +        return base_size
> > > +
> > >      # Check the rootfs size against IMAGE_ROOTFS_MAXSIZE (if set)
> > >      if rootfs_maxsize:
> > >          rootfs_maxsize_int = int(rootfs_maxsize)
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > 


      reply	other threads:[~2016-09-13  7:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05  8:34 [PATCH] image.bbclass: do not check size of the debugfs image André Draszik
2016-09-12 15:26 ` André Draszik
2016-09-12 15:36   ` Burton, Ross
2016-09-13  7:44     ` André Draszik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473752680.5279.3.camel@andred.net \
    --to=git@andred.net \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox