From: Phil Blundell <pb@pbcl.net>
To: Sujith H <sujith.h@gmail.com>, openembedded-core@lists.openembedded.org
Cc: Sujith Haridasan <Sujith_Haridasan@mentor.com>
Subject: Re: [PATCH] x264: add textrel to INSANE_SKIP to skip the warning
Date: Thu, 15 Sep 2016 11:07:10 +0100 [thread overview]
Message-ID: <1473934030.3329.337.camel@pbcl.net> (raw)
In-Reply-To: <1473922370-4325-1-git-send-email-sujith.h@gmail.com>
On Thu, 2016-09-15 at 12:22 +0530, Sujith H wrote:
> From: Fahad Usman <fahad_usman@mentor.com>
>
> This change help fix the warning message:
>
> x264/r2491+gitAUTOINC+c8a773ebfc-r0/packages-
> split/x264/usr/lib/libx264.so.144' has relocations in .text [textrel]
>
> Adding textrel to INSANE_SKIP resolves this issue.
This is a poor commit message. Adding textrel to INSANE_SKIP prevents
the check from being done, so it is fairly self-evident that it will
suppress the corresponding warning message. Please add an explanation
of why this is an appropriate thing to do, i.e. why the textrels are
present and why you can't get rid of them by other means.
In particular please clarify whether you want to do this because the
textrels are absolutely unavoidable for some reason on your
architecture, or just because you think this is a good trade-off for
performance. If the latter then I think the change probably belongs in
a distro or BSP layer not in oe-core.
p.
next prev parent reply other threads:[~2016-09-15 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 6:52 [PATCH] x264: add textrel to INSANE_SKIP to skip the warning Sujith H
2016-09-15 10:07 ` Phil Blundell [this message]
2016-09-21 8:14 ` sujith h
2016-09-21 9:17 ` Phil Blundell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473934030.3329.337.camel@pbcl.net \
--to=pb@pbcl.net \
--cc=Sujith_Haridasan@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sujith.h@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox