Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patrick Ohly <patrick.ohly@intel.com>
Cc: Christopher Larson <clarson@kergoth.com>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] toolchain-shar-relocate.sh: Add error-handling
Date: Fri, 23 Sep 2016 17:49:46 +0100	[thread overview]
Message-ID: <1474649386.30475.2.camel@linuxfoundation.org> (raw)
In-Reply-To: <1474642615.8561.10.camel@intel.com>

On Fri, 2016-09-23 at 16:56 +0200, Patrick Ohly wrote:
> On Fri, 2016-09-23 at 15:48 +0100, Richard Purdie wrote:
> > 
> > On Wed, 2016-09-21 at 19:06 -0700, Christopher Larson wrote:
> > > 
> > > 
> > > On Wed, Sep 21, 2016 at 12:54 AM, <mariano.lopez@linux.intel.com>
> > > wrote:
> > > > 
> > > > diff --git a/meta/files/toolchain-shar-relocate.sh
> > > > b/meta/files/toolchain-shar-relocate.sh
> > > > index d4bcf0e..e491153 100644
> > > > --- a/meta/files/toolchain-shar-relocate.sh
> > > > +++ b/meta/files/toolchain-shar-relocate.sh
> > > > @@ -1,3 +1,8 @@
> > > > +if ! xargs --version > /dev/null 2>&1; then
> > > > +       echo "xargs is required by the relocation script,
> > > > please
> > > > install it firts. Abort!"
> > > > +       exit 1
> > > > +fi
> > > > 
> > > This is pointless, xargs is mandated by posix/sus.
> > It appears we have some users with stripped down containers where
> > it
> > hasn't been installed though and having a user readable message is
> > better
> ... and even better is one without typos ;-}
> 
> s/firts/first/

Indeed. Fix queued in -next.

Cheers,

Richard


  reply	other threads:[~2016-09-23 16:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1474444335.git.mariano.lopez@linux.intel.com>
2016-09-21  7:54 ` [PATCH 1/1] toolchain-shar-relocate.sh: Add error-handling mariano.lopez
2016-09-22  2:06   ` Christopher Larson
2016-09-23 14:48     ` Richard Purdie
2016-09-23 14:56       ` Patrick Ohly
2016-09-23 16:49         ` Richard Purdie [this message]
2016-09-26 13:13         ` mariano.lopez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474649386.30475.2.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=clarson@kergoth.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=patrick.ohly@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox