Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "André Draszik" <git@andred.net>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] cve-check-tool: report progress when downloading CVE database
Date: Wed, 28 Sep 2016 12:56:29 +0100	[thread overview]
Message-ID: <1475063789.5024.13.camel@andred.net> (raw)
In-Reply-To: <CAJTo0Lb9AmtOVA73xVkqmXJzQfvQQc0wBspv+miNo_eyuBUCmg@mail.gmail.com>

Ups, sorry for that... :-(

Should I send a patch against master-next, or against master?

a.

On Mi, 2016-09-28 at 11:54 +0100, Burton, Ross wrote:
> On 26 September 2016 at 16:42, André Draszik <git@andred.net> wrote:
> 
> > 
> > ++static int progress_callback_new(void *ptr, curl_off_t dltotal,
> > curl_off_t dlnow, curl_off_t ultotal, curl_off_t ulnow)
> > ++{
> > ++        (void) ultotal;
> > ++        (void) ulnow;
> > ++
> > ++        struct percent_t *percent = (struct percent_t *) ptr;
> > ++
> > ++        if (dltotal && percent) {
> > ++                long diff = percent->end - percent->start;
> > ++                if (diff) {
> > ++                        fprintf(stderr,"completed: %lu%%\r",
> > percent->start + (diff * dlnow / dltotal));
> > ++                }
> > ++        }
> > ++
> > ++        return 0;
> > ++}
> > 
> 
> This fails on the autobuilder cluster:
> 
> > 
> > ../../cve-check-tool-5.6.4/src/library/fetch.c: In function
> 'progress_callback_new':
> > 
> > ../../cve-check-tool-5.6.4/src/library/fetch.c:55:54: error: format
> > '%lu'
> expects argument of type 'long unsigned int', but argument 3 has type
> 'curl_off_t {aka long long int}' [-Werror=format=]
> > 
> >                          fprintf(stderr,"completed: %lu%%\r",
> percent->start + (diff * dlnow / dltotal));
> > 
> >                                                       ^
> 
> Ross


  reply	other threads:[~2016-09-28 11:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26 15:42 [PATCH 0/2] cve-check-tool progress reporting André Draszik
2016-09-26 15:42 ` [PATCH 1/2] cve-check-tool: convert do_populate_cve_db() from python to sh André Draszik
2016-09-26 15:42 ` [PATCH 2/2] cve-check-tool: report progress when downloading CVE database André Draszik
2016-09-28 10:54   ` Burton, Ross
2016-09-28 11:56     ` André Draszik [this message]
2016-09-28 11:57       ` Burton, Ross
2016-09-28 12:05 ` [PATCH v2 1/2] cve-check-tool: convert do_populate_cve_db() from python to sh André Draszik
2016-09-28 12:05   ` [PATCH v2 2/2] cve-check-tool: report progress when downloading CVE database André Draszik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475063789.5024.13.camel@andred.net \
    --to=git@andred.net \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox