From: Saul Wold <saul.wold@intel.com>
To: Ed Bartosh <ed.bartosh@linux.intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [wic][PATCH] mkefidisk.wks: use partition UUID and GPT partition table
Date: Sun, 02 Oct 2016 13:47:46 -0700 [thread overview]
Message-ID: <1475441266.18115.116.camel@intel.com> (raw)
In-Reply-To: <1475249810-1235-1-git-send-email-ed.bartosh@linux.intel.com>
On Fri, 2016-09-30 at 18:36 +0300, Ed Bartosh wrote:
> This is a preparation to use mkefidisk as a default wks for
> genericx86* BSPs. This change enables usage of partition UUID
> instead of device name to specify root partition in kernel
> command line. It should make images to boot on devices with
> boot device names that differ from what's mentioned in wks file.
>
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
> scripts/lib/wic/canned-wks/mkefidisk.wks | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/lib/wic/canned-wks/mkefidisk.wks
> b/scripts/lib/wic/canned-wks/mkefidisk.wks
> index 696e94e..73886ab 100644
> --- a/scripts/lib/wic/canned-wks/mkefidisk.wks
> +++ b/scripts/lib/wic/canned-wks/mkefidisk.wks
> @@ -4,8 +4,8 @@
>
> part /boot --source bootimg-efi --sourceparams="loader=grub-efi" --
> ondisk sda --label msdos --active --align 1024
>
> -part / --source rootfs --ondisk sda --fstype=ext4 --label platform
> --align 1024
> +part / --source rootfs --ondisk sda --fstype=ext4 --label platform
> --align 1024 --use-uuid
>
> part swap --ondisk sda --size 44 --label swap1 --fstype=swap
>
> -bootloader --timeout=10 --append="rootwait rootfstype=ext4
> console=ttyPCH0,115200 console=tty0 vmalloc=256MB snd-hda-
> intel.enable_msi=0"
> +bootloader --ptable gpt --timeout=10 --append="rootwait
> rootfstype=ext4 console=ttyPCH0,115200 console=tty0 vmalloc=256MB
> snd-hda-intel.enable_msi=0"
NAK!
Not all devices can handle GPT correct it seems, I can't use this
version to boot a Turobot for example, where is was usable before.
The use-uuid works.
Sau!
> --
> 2.1.4
>
prev parent reply other threads:[~2016-10-02 20:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 15:36 [wic][PATCH] mkefidisk.wks: use partition UUID and GPT partition table Ed Bartosh
2016-10-02 20:47 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475441266.18115.116.camel@intel.com \
--to=saul.wold@intel.com \
--cc=ed.bartosh@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox