From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: Christophe Chapuis <chris.chapuis@gmail.com>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [krogoth][PATCH] binutils: fix AR issue when opkg is unpacking IPKs containing empty entries
Date: Thu, 06 Oct 2016 14:10:24 +0100 [thread overview]
Message-ID: <1475759424.30475.556.camel@linuxfoundation.org> (raw)
In-Reply-To: <CA+chaQeVPFGamX=E8o6SNTTth5ytm9EdrecFtW1z4NfTRNSiDA@mail.gmail.com>
On Thu, 2016-10-06 at 13:12 +0200, Martin Jansa wrote:
> I see, there is ^M after empty in the actual .patch file, if I read
> the git format-patch output it shows ^M, but the git webUI gets
> confused and shows ^M as normal line feed.
>
> ++ if ![string match "empty^M" $got] {
>
> Does it work for you when cherry-picking from the branch.
>
> Here is the same change in binutils git repo:
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blobdiff;f
> =binutils/testsuite/binutils-
> all/ar.exp;h=45be9b1b594b39624f3e010f50bf98892fb64549;hp=508ae9c1d756
> 2c8b0a2c090a93e35acdba733944;hb=4fc874242f8f1bf17cf6e65b159dd804e793e
> 6cd;hpb=23a4bd22c75862fdbaa5faef59b9094ec738f675
>
> It shows '\r' so it isn't there by accident.
I've been able to cherry-pick it, thanks. I figured it was something
odd going on with the mailing list damaging line returns.
Cheers,
Richard
prev parent reply other threads:[~2016-10-06 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 8:23 [krogoth][PATCH] binutils: fix AR issue when opkg is unpacking IPKs containing empty entries Martin Jansa
2016-10-06 10:45 ` Richard Purdie
2016-10-06 10:46 ` Martin Jansa
2016-10-06 10:54 ` Martin Jansa
2016-10-06 11:12 ` Martin Jansa
2016-10-06 13:10 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475759424.30475.556.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=chris.chapuis@gmail.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox