From: Saul Wold <saul.wold@intel.com>
To: Ed Bartosh <ed.bartosh@linux.intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [wic][PATCH] mkefidisk.wks: update kernel command line
Date: Fri, 07 Oct 2016 14:33:18 -0700 [thread overview]
Message-ID: <1475875998.18115.234.camel@intel.com> (raw)
In-Reply-To: <1475769473-8356-1-git-send-email-ed.bartosh@linux.intel.com>
On Thu, 2016-10-06 at 18:57 +0300, Ed Bartosh wrote:
> Used ttyS0 console.
> Removed usage of ttyPCH0 (FRI2 leftover)
> Decreased bootloader timeout to 5 seconds
> Removed 'vmalloc=256MB snd-hda-intel.enable_msi=0' as it's not needed
> for any of reference BSPs.
>
These changes are needed for newer hardware.
I further tested with and with out the GPT enabled and found that what
ever testing I did original was invalid and GPT is OK for both NUC and
MinnowboardMax.
So I think we can re-enable that for mkefidisk.wks.
These same changes should be applies to systemd-bootdisk.wks also.
Thanks
Sau!
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
> scripts/lib/wic/canned-wks/mkefidisk.wks | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/lib/wic/canned-wks/mkefidisk.wks
> b/scripts/lib/wic/canned-wks/mkefidisk.wks
> index 668ca92..7c287f7 100644
> --- a/scripts/lib/wic/canned-wks/mkefidisk.wks
> +++ b/scripts/lib/wic/canned-wks/mkefidisk.wks
> @@ -8,4 +8,4 @@ part / --source rootfs --ondisk sda --fstype=ext4 --
> label platform --align 1024
>
> part swap --ondisk sda --size 44 --label swap1 --fstype=swap
>
> -bootloader --timeout=10 --append="rootwait rootfstype=ext4
> console=ttyPCH0,115200 console=tty0 vmalloc=256MB snd-hda-
> intel.enable_msi=0"
> +bootloader --timeout=5 --append="rootfstype=ext4
> console=ttyS0,115200 console=tty0"
> --
> 2.1.4
>
next prev parent reply other threads:[~2016-10-07 21:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 10:33 [wic][PATCH 0/4] use PARTUUID for MSDOS partitions Ed Bartosh
2016-10-06 10:33 ` [wic][PATCH 1/4] wic: set PARTUUID only for gpt partition table Ed Bartosh
2016-10-06 10:33 ` [wic][PATCH 2/4] wic: generate PARTUUID for MDOS partitions Ed Bartosh
2016-10-06 10:33 ` [wic][PATCH 3/4] wic: rewrite MBR disk identifier Ed Bartosh
2016-10-06 10:33 ` [wic][PATCH 4/4] mkefidisk.wks: use MSDOS partition table Ed Bartosh
2016-10-06 16:02 ` [wic][PATCH 0/4] use PARTUUID for MSDOS partitions Saul Wold
2016-10-06 15:57 ` [wic][PATCH] mkefidisk.wks: update kernel command line Ed Bartosh
2016-10-07 21:33 ` Saul Wold [this message]
2016-10-10 7:50 ` [wic][PATCH] canned-wks: use GPT partition table Ed Bartosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475875998.18115.234.camel@intel.com \
--to=saul.wold@intel.com \
--cc=ed.bartosh@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox