From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Stephano Cetola <stephano.cetola@linux.intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V2] subprocess: remove strings and migrate to direct arrays
Date: Sun, 09 Oct 2016 12:42:19 +0100 [thread overview]
Message-ID: <1476013339.30475.679.camel@linuxfoundation.org> (raw)
In-Reply-To: <20161007030947.12602-2-stephano.cetola@linux.intel.com>
On Thu, 2016-10-06 at 20:09 -0700, Stephano Cetola wrote:
> When using subprocess call and check_output, it is better to use
> arrays
> rather than strings when possible to avoid whitespace and quoting
> problems.
>
> [ YOCTO #9342 ]
>
> Signed-off-by: Stephano Cetola <stephano.cetola@linux.intel.com>
> ---
> meta/lib/oe/distro_check.py | 2 +-
> meta/lib/oe/package.py | 13 +--
> meta/lib/oe/package_manager.py | 218 ++++++++++++++++++++-----------
> ----------
> 3 files changed, 114 insertions(+), 119 deletions(-)
This triggered a lot of errors on the autobuilder:
http://autobuilder.yocto.io:8010/builders/build-appliance/builds/70
http://autobuilder.yocto.io:8010/builders/nightly-x86/builds/75
http://autobuilder.yocto.io:8010/builders/nightly-x86-64/builds/73
http://autobuilder.yocto.io:8010/builders/nightly-x86-64-lsb/builds/72
http://autobuilder.yocto.io:8010/builders/nightly-x86-lsb/builds/73
http://autobuilder.yocto.io:8010/builders/nightly-wic/builds/73
next prev parent reply other threads:[~2016-10-09 11:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 3:09 [PATCH V2] Cleanup subprocess calls Stephano Cetola
2016-10-07 3:09 ` [PATCH V2] subprocess: remove strings and migrate to direct arrays Stephano Cetola
2016-10-09 11:42 ` Richard Purdie [this message]
2016-10-09 11:44 ` Richard Purdie
2016-10-10 13:15 ` Stephano Cetola
2016-10-10 14:22 ` Christopher Larson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476013339.30475.679.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=stephano.cetola@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox