Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Ulf Magnusson <ulfalizer@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH v2] bitbake: bitbake-layers: Make show-recipes show PR
Date: Mon, 17 Oct 2016 20:30:27 +0200	[thread overview]
Message-ID: <1476729027-5072-2-git-send-email-ulfalizer@gmail.com> (raw)
In-Reply-To: <1476729027-5072-1-git-send-email-ulfalizer@gmail.com>

Only PE and PV were shown, which might have been an oversight. The
tuples passed to version_str() contain three elements (PE, PV, and PR),
not two.

Also remove now-redundant default 'pr' argument in
QueryPlugin.version_str().

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
 bitbake/lib/bblayers/query.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/bitbake/lib/bblayers/query.py b/bitbake/lib/bblayers/query.py
index ee1e7c8..4d6999a 100644
--- a/bitbake/lib/bblayers/query.py
+++ b/bitbake/lib/bblayers/query.py
@@ -28,7 +28,7 @@ class QueryPlugin(LayerPlugin):
             layername = self.get_layer_name(layerdir)
             logger.plain("%s  %s  %d" % (layername.ljust(20), layerdir.ljust(40), pri))
 
-    def version_str(self, pe, pv, pr = None):
+    def version_str(self, pe, pv, pr):
         verstr = "%s" % pv
         if pr:
             verstr = "%s-%s" % (verstr, pr)
@@ -212,10 +212,10 @@ skipped recipes will also be listed, with a " (skipped)" suffix.
                         if not items_listed:
                             logger.plain('=== %s ===' % title)
                             items_listed = True
-                        print_item(preffile, p, self.version_str(pref[0][0], pref[0][1]), preflayer, True)
+                        print_item(preffile, p, self.version_str(*pref[0]), preflayer, True)
                         for (provfile, provlayer, provver) in provs:
                             if provfile != preffile:
-                                print_item(provfile, p, self.version_str(provver[0], provver[1]), provlayer, False)
+                                print_item(provfile, p, self.version_str(*provver), provlayer, False)
                         # Ensure we don't show two entries for BBCLASSEXTENDed recipes
                         preffiles.append(preffile)
 
-- 
2.7.4



  reply	other threads:[~2016-10-17 18:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 18:30 [PATCH v2] bitbake: bitbake-layers: Make show-recipes show PR Ulf Magnusson
2016-10-17 18:30 ` Ulf Magnusson [this message]
2016-10-17 21:42   ` Paul Eggleton
2016-10-17 22:33     ` Ulf Magnusson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476729027-5072-2-git-send-email-ulfalizer@gmail.com \
    --to=ulfalizer@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox