Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Wold, Saul" <saul.wold@intel.com>
To: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>,
	"richard.purdie@linuxfoundation.org"
	<richard.purdie@linuxfoundation.org>,
	 "akuster@mvista.com" <akuster@mvista.com>
Subject: Re: [PATCH][master][krogoth] archiver: fix gcc-source handling
Date: Thu, 27 Oct 2016 20:32:09 +0000	[thread overview]
Message-ID: <1477600328.2097.1.camel@intel.com> (raw)
In-Reply-To: <1476124325-6771-1-git-send-email-sgw@linux.intel.com>

This has been merged to master ping for Krogoth

Sau!

On Mon, 2016-10-10 at 11:32 -0700, Saul Wold wrote:
> 
> The source archiver was not handling the gcc-source target correctly,
> since it uses the
> work-shared directory, we don't want to unpack and patch it twice,
> just as the comments
> say, but the code was not there to check for the gcc-source target.
> 
> [YOCTO #10265]
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
> 
>  meta/classes/archiver.bbclass | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/archiver.bbclass
> b/meta/classes/archiver.bbclass
> index 1d8e863..9239983 100644
> --- a/meta/classes/archiver.bbclass
> +++ b/meta/classes/archiver.bbclass
> @@ -303,9 +303,10 @@ python do_unpack_and_patch() {
>          return
>      ar_outdir = d.getVar('ARCHIVER_OUTDIR', True)
>      ar_workdir = d.getVar('ARCHIVER_WORKDIR', True)
> +    pn = d.getVar('PN', True)
>  
>      # The kernel class functions require it to be on work-shared, so
> we dont change WORKDIR
> -    if not bb.data.inherits_class('kernel-yocto', d):
> +    if not (bb.data.inherits_class('kernel-yocto', d) or
> pn.startswith('gcc-source')):
>          # Change the WORKDIR to make do_unpack do_patch run in
> another dir.
>          d.setVar('WORKDIR', ar_workdir)
>  
> @@ -323,7 +324,7 @@ python do_unpack_and_patch() {
>          oe.path.copytree(src, src_orig)
>  
>      # Make sure gcc and kernel sources are patched only once
> -    if not ((d.getVar('SRC_URI', True) == "" or
> bb.data.inherits_class('kernel-yocto', d))):
> +    if not (d.getVar('SRC_URI', True) == "" or
> (bb.data.inherits_class('kernel-yocto', d) or pn.startswith('gcc-
> source'))):
>          bb.build.exec_func('do_patch', d)
>  
>      # Create the patches
> -- 
> 2.7.4
> 

  parent reply	other threads:[~2016-10-27 20:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-10 18:32 [PATCH][master][krogoth] archiver: fix gcc-source handling Saul Wold
2016-10-17 14:25 ` Saul Wold
2016-10-17 23:22   ` akuster808
2016-10-27 20:32 ` Wold, Saul [this message]
2016-10-27 21:36   ` akuster808

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477600328.2097.1.camel@intel.com \
    --to=saul.wold@intel.com \
    --cc=akuster@mvista.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox