Re: [Patch 01/13] arch-mips: Add MACHINEOVERRIDES variables to reduce duplication

["André Draszik" <git@andred.net>]

On Mon, 2016-11-07 at 18:32 -0800, Andre McCurdy wrote:
> On Mon, Nov 7, 2016 at 9:30 AM, Khem Raj <raj.khem@gmail.com> wrote:
> > 
> > On 11/7/16 7:01 AM, Zubair Lutfullah Kakakhel wrote:
> > > In some cases, each MIPS variant in a recipe requires a duplicate
> > > line. Even if the passed flag is the same.
> > > 
> > > Add global MACHINEOVERRIDES variables for the following
> > >  * mipsarch           : All MIPS
> > >  * mipsarchr6         : All MIPS R6
> > >  * mipsarcho32{el}    : All MIPS o32
> > >  * mipsarchn32{el}    : All MIPS n32
> > >  * mipsarchn64{el}    : All MIPS n64
> > > 
> > > This is intended to reduce duplications in recipes
> > > 
> > > [YOCTO #10404]
> > > 
> > > Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
> > > ---
> > >  meta/conf/machine/include/mips/arch-mips.inc | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > > diff --git a/meta/conf/machine/include/mips/arch-mips.inc
> > > b/meta/conf/machine/include/mips/arch-mips.inc
> > > index 6069ca1..5b42841 100644
> > > --- a/meta/conf/machine/include/mips/arch-mips.inc
> > > +++ b/meta/conf/machine/include/mips/arch-mips.inc
> > > @@ -50,6 +50,13 @@ MIPSPKGSFX_32R6 = "${@bb.utils.contains('TUNE_FEATU
> > > RES', 'mipsisa32r6', 'isa32',
> > >  TUNE_ARCH =
> > > "mips${MIPSPKGSFX_32R6}${MIPSPKGSFX_64R6}${MIPSPKGSFX_BYTE}${MIPSPKGSF
> > > X_R6}${MIPSPKGSFX_ENDIAN}"
> > >  TUNE_PKGARCH = "${MIPSPKGSFX_VARIANT_tune-
> > > ${DEFAULTTUNE}}${MIPSPKGSFX_FPU}${MIPSPKGSFX_ABI}"
> > > 
> > > +# Various Global Machine Overrides
> > > +MACHINEOVERRIDES =. "mipsarch:"
> > > +MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'r6',
> > > 'mipsarchr6:', '' ,d)}"
> > > +MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'n32',
> > > 'mipsarchn32${MIPSPKGSFX_ENDIAN}:', '' ,d)}"
> > > +MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'o32',
> > > 'mipsarcho32${MIPSPKGSFX_ENDIAN}:', '' ,d)}"
> > > +MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'n64',
> > > 'mipsarch64${MIPSPKGSFX_ENDIAN}:', '' ,d)}"
> > 
> > how about mips16 ?
> 
> We explicitly removed _thumb as an over-ride for ARM, so adding the
> equivalent for MIPS would be odd, unless you see a clear need for it?

There is a need as not all code compiles in MIPS16e mode... The override is
already there in OE - modelled after the original (now gone) thumb override.

http://git.openembedded.org/openembedded-core/tree/meta/conf/machine/include/mips/feature-mips-mips16e.inc

Cheers,
Andre'