From: "André Draszik" <git@andred.net>
To: Denys Dmytriyenko <denis@denix.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2 1/3] module.bbclass: use Module.symvers for dependants
Date: Thu, 17 Nov 2016 10:22:18 +0000 [thread overview]
Message-ID: <1479378138.27546.1.camel@andred.net> (raw)
In-Reply-To: <20161116201836.GA26131@denix.org>
Hi,
On Wed, 2016-11-16 at 15:18 -0500, Denys Dmytriyenko wrote:
> On Thu, Aug 18, 2016 at 08:56:24AM +0100, André Draszik wrote:
> >
> > @@ -24,6 +34,11 @@ module_do_install() {
> > CC="${KERNEL_CC}" LD="${KERNEL_LD}" \
> > O=${STAGING_KERNEL_BUILDDIR} \
> > ${MODULES_INSTALL_TARGET}
> > +
> > + install -d -m0755 ${D}${includedir}/${BPN}
> > + cp -a --no-preserve=ownership ${B}/Module.symvers
> > ${D}${includedir}/${BPN}
>
> Hmm, why is Module.symvers expected to be in the root of ${B}? This seems
> like
> a very artificial assumption/requirement!
[...]
> I wonder if this should have been rolled into ${MODULES_INSTALL_TARGET}
> step...
What about adding a (lazy ?=) variable to be able to override the location
of Module.symvers within ${B}, or alternatively using find to automatically
detect it? I guess there could also be more than one in theory? Do you have
something different in mind?
A.
next prev parent reply other threads:[~2016-11-17 10:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 15:25 [PATCH 0/2] fixing kernel module cross-recipe dependency André Draszik
2016-08-17 15:25 ` [PATCH 1/2] module.bbclass: use Module.symvers for dependants André Draszik
2016-08-17 15:25 ` [PATCH 2/2] kernel-module-split.bbclass: generate dependencies across recipes André Draszik
2016-08-17 16:12 ` [PATCH] kernel-module-split.bbclass: no need for running depmod André Draszik
2016-08-18 7:56 ` [PATCH v2 0/3] fixing kernel module cross-recipe dependency André Draszik
2016-08-18 7:56 ` [PATCH v2 1/3] module.bbclass: use Module.symvers for dependants André Draszik
2016-11-16 20:18 ` Denys Dmytriyenko
2016-11-17 10:22 ` André Draszik [this message]
2016-11-17 18:47 ` Denys Dmytriyenko
2016-08-18 7:56 ` [PATCH v2 2/3] kernel-module-split.bbclass: generate dependencies across recipes André Draszik
2016-08-18 7:56 ` [PATCH v2 3/3] kernel-module-split.bbclass: no need for running depmod André Draszik
2016-08-26 10:38 ` [PATCH v2 0/3] fixing kernel module cross-recipe dependency André Draszik
2016-09-05 11:18 ` André Draszik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479378138.27546.1.camel@andred.net \
--to=git@andred.net \
--cc=denis@denix.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox