From: Patrick Ohly <patrick.ohly@intel.com>
To: Chen Qi <Qi.Chen@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V2 4/4] package.bbclass: support persistent /var/log
Date: Tue, 13 Dec 2016 09:38:29 +0100 [thread overview]
Message-ID: <1481618309.17535.260.camel@intel.com> (raw)
In-Reply-To: <6c128696461dd6e37818cbad168a048575b97f5a.1481616098.git.Qi.Chen@windriver.com>
On Tue, 2016-12-13 at 16:04 +0800, Chen Qi wrote:
> - fs_perms_tables = 'files/fs-perms.txt'
> + fs_perms_tables = ['files/fs-perms-persistent-log.txt',
> 'files/fs-perms.txt'][d.getVar('VOLATILE_LOG_DIR', True) == 'yes']
Now that the rest of the changes treat VOLATILE_LOG_DIR as a boolean,
this code here also needs to be changed. Otherwise VOLATILE_LOG_DIR=1 or
VOLATILE_LOG_DIR=y won't work correctly.
You might also want to change the description of the variable in the
first patch to mention those other values.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
prev parent reply other threads:[~2016-12-13 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 8:04 [PATCH V2 0/4] Persistent /var/log support Chen Qi
2016-12-13 8:04 ` [PATCH V2 1/4] bitbake.conf: add VOLATILE_LOG_DIR variable Chen Qi
2016-12-13 8:04 ` [PATCH V2 2/4] base-files: respect VOLATILE_LOG_DIR Chen Qi
2016-12-13 8:04 ` [PATCH V2 3/4] initscripts: support persistent /var/log Chen Qi
2016-12-13 8:04 ` [PATCH V2 4/4] package.bbclass: " Chen Qi
2016-12-13 8:38 ` Patrick Ohly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481618309.17535.260.camel@intel.com \
--to=patrick.ohly@intel.com \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox