From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay1.mentorg.com (relay1.mentorg.com [192.94.38.131]) by mail.openembedded.org (Postfix) with ESMTP id C49C977208 for ; Wed, 14 Dec 2016 13:29:59 +0000 (UTC) Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-03.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1cH9dA-00040j-G1 from Awais_Belal@mentor.com ; Wed, 14 Dec 2016 05:30:00 -0800 Received: from SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) by SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 14 Dec 2016 13:29:57 +0000 Received: from SVR-IES-MBX-03.mgc.mentorg.com ([fe80::1072:fb6e:87f1:ed17]) by SVR-IES-MBX-03.mgc.mentorg.com ([fe80::1072:fb6e:87f1:ed17%22]) with mapi id 15.00.1210.000; Wed, 14 Dec 2016 13:29:57 +0000 From: "Belal, Awais" To: "Burton, Ross" Thread-Topic: [OE-core] [PATCH 1/2] grub_git: extend recipe for proper target deployment Thread-Index: AQHSVUvSV9G8LvsP8EWmyzHmbHpAe6EHcSqx Date: Wed, 14 Dec 2016 13:29:57 +0000 Message-ID: <1481722196426.25330@mentor.com> References: <1481627960-3608-1-git-send-email-awais_belal@mentor.com>, In-Reply-To: Accept-Language: en-US, en-IE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [137.202.0.87] MIME-Version: 1.0 Cc: OE-core Subject: Re: [PATCH 1/2] grub_git: extend recipe for proper target deployment X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2016 13:30:00 -0000 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_148172219642625330mentorcom_" --_000_148172219642625330mentorcom_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Ross, >> +RDEPENDS_${PN}_class-target =3D "diffutils freetype" > Does this really need to be class-target-specific? Without the class-target override I get ERROR: Nothing RPROVIDES 'diffutils-native' (but virtual:native:/data/amd_y= octo/poky/meta/recipes-bsp/grub/grub_git.bb RDEPENDS on or otherwise requir= es it) so I believe this is necessary in this case. Are you through your review? I= f so, just let me know and I'll send a v2 fixing the other DEPENDS issue yo= u pointed out. BR, Awais ________________________________ From: Burton, Ross Sent: Tuesday, December 13, 2016 7:17 PM To: Belal, Awais Cc: OE-core Subject: Re: [OE-core] [PATCH 1/2] grub_git: extend recipe for proper targe= t deployment On 13 December 2016 at 11:19, Awais Belal > wrote: +DEPENDS_class-target +=3D "grub-native" The native magic won't generate dependencies on itself, so this can just be= DEPENDS. +RDEPENDS_${PN}_class-target =3D "diffutils freetype" Does this really need to be class-target-specific? Ross --_000_148172219642625330mentorcom_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

Hi Ross,


>> +RDEPENDS_${PN}_class-target =3D "diffutils freetype&q= uot;
> Does this really need to be class-target-specific?

Without the class-target override I get


ERROR: Nothing RPROVIDES 'diffutils-native' (but virtual:native:/data/am= d_yocto/poky/meta/recipes-bsp/grub/grub_git.bb RDEPENDS on or otherwise req= uires it)


so I believe this is necessary in this case. Are you through your review= ? If so, just let me know and I'll send a v2 fixing the other DEPENDS issue= you pointed out.


BR,
Awais
From: Burton, Ross <ros= s.burton@intel.com>
Sent: Tuesday, December 13, 2016 7:17 PM
To: Belal, Awais
Cc: OE-core
Subject: Re: [OE-core] [PATCH 1/2] grub_git: extend recipe for prope= r target deployment
 

On 13 December 2016 at 11:19, Awais Belal <awais_belal= @mentor.com> wrote: 
+DEPENDS_class-target +=3D "grub-native"

The native magic won't generate dependencies on itself, so this can ju= st be DEPENDS.
 
+RDEPENDS_${PN}_class-target =3D "diffutils freetype"

Does this really need to be class-target-specific?

Ross
--_000_148172219642625330mentorcom_--