From: Phil Blundell <pb@pbcl.net>
To: "Maxin B. John" <maxin.john@intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] busybox: update flock behavior to match upstream
Date: Tue, 17 Jan 2017 12:59:37 +0000 [thread overview]
Message-ID: <1484657977.10018.78.camel@pbcl.net> (raw)
In-Reply-To: <1461230647-19298-1-git-send-email-maxin.john@intel.com>
On Thu, 2016-04-21 at 12:24 +0300, Maxin B. John wrote:
>
+-
> +- if (argv[0])
> +- return spawn_and_wait(argv);
> +-
> ++ if (argv[0]) {
> ++ cmd_args[0] = getenv("SHELL");
> ++ if (!cmd_args[0])
> ++ cmd_args[0] = (char*)DEFAULT_SHELL;
> ++ cmd_args[1] = (char*)"-c";
> ++ cmd_args[2] = argv[0];
> ++ cmd_args[3] = NULL;
> ++ return spawn_and_wait(cmd_args);
> ++ }
> + return EXIT_SUCCESS;
> + }
>
This patch seems to completely break the behaviour of flock when
invoked without "-c". For example, compare the behaviour of:
flock /tmp/lock echo it works
before and after. Please revert this patch until and unless it can be
fixed.
p.
next prev parent reply other threads:[~2017-01-17 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 9:24 [PATCH] busybox: update flock behavior to match upstream Maxin B. John
2017-01-17 12:59 ` Phil Blundell [this message]
2017-01-17 13:25 ` Burton, Ross
2017-01-17 15:05 ` Maxin B. John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484657977.10018.78.camel@pbcl.net \
--to=pb@pbcl.net \
--cc=maxin.john@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox