From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patrick Ohly <patrick.ohly@intel.com>,
Alexander Kanavin <alexander.kanavin@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCHv2] qemu: Upgrade to 2.7.1
Date: Mon, 23 Jan 2017 14:32:32 +0000 [thread overview]
Message-ID: <1485181952.30673.22.camel@linuxfoundation.org> (raw)
In-Reply-To: <1485181781.20333.39.camel@intel.com>
On Mon, 2017-01-23 at 15:29 +0100, Patrick Ohly wrote:
> On Mon, 2017-01-23 at 16:01 +0200, Alexander Kanavin wrote:
> >
> > On 01/20/2017 09:44 PM, Patrick Ohly wrote:
> >
> > >
> > > In contrast to Alexander, I would also keep
> > > http://wiki.qemu-project.org/download/${BP}.tar.bz2 in
> > > qemu_2.7.1.bb
> > > with SRC_URI =+ because then there can be a qemu_git.bb with a
> > > different
> > > URL than the one above.
> > I would discourage creation of such separate _git recipes, unless
> > there
> > is a clear benefit to the whole of oe-core. They are almost always
> > untested and neglected, and eventually removed because they're
> > outdated
> > and broken and no one cares.
> I wasn't suggesting to add one, just using the possibility that one
> might want to add one as the rationale for keeping the download URL
> for
> the tarball out of the .inc file.
>
> It's all rather subjective and hinges on the likelihood of adding a
> _git.bb (don't include it in the .inc) vs. adding more than one
> versioned .bb (then including the common download in the .inc reduces
> duplication).
There is actually an alternative proposal somewhere in bugzilla which
would be to leave enough markup that we can easily enable a git
version. That markup mostly being the git:// url in a variable. Ross
was looking at that.
Cheers,
Richard
prev parent reply other threads:[~2017-01-23 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 18:12 [PATCHv2] qemu: Upgrade to 2.7.1 Aníbal Limón
2017-01-20 19:44 ` Patrick Ohly
2017-01-23 14:01 ` Alexander Kanavin
2017-01-23 14:29 ` Patrick Ohly
2017-01-23 14:32 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485181952.30673.22.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=alexander.kanavin@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=patrick.ohly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox