Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: leonardo.sandoval.gonzalez@linux.intel.com,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/4] selftest/buildoptions: force compile task instead of cleaning sstates
Date: Tue, 31 Jan 2017 23:16:00 +0000	[thread overview]
Message-ID: <1485904560.14144.18.camel@linuxfoundation.org> (raw)
In-Reply-To: <d08deb0bac4d1f00b7d0467098addb5af0583bf2.1485902097.git.leonardo.sandoval.gonzalez@linux.intel.com>

On Tue, 2017-01-31 at 16:50 -0600,
leonardo.sandoval.gonzalez@linux.intel.com wrote:
> From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
> 
> There is no need to clean m4 sstates, use force instead.
> 
> Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.in
> tel.com>
> ---
>  meta/lib/oeqa/selftest/buildoptions.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/meta/lib/oeqa/selftest/buildoptions.py
> b/meta/lib/oeqa/selftest/buildoptions.py
> index 004b2dd..a83088f 100644
> --- a/meta/lib/oeqa/selftest/buildoptions.py
> +++ b/meta/lib/oeqa/selftest/buildoptions.py
> @@ -36,8 +36,7 @@ class ImageOptionsTests(oeSelfTest):
>          p = get_bb_var('SYSROOT_DESTDIR', 'ccache-native') +
> get_bb_var('bindir', 'ccache-native') + "/" + "ccache"
>          self.assertTrue(os.path.isfile(p), msg = "No ccache found
> (%s)" % p)
>          self.write_config('INHERIT += "ccache"')
> -        bitbake("m4 -c cleansstate")
> -        bitbake("m4 -c compile")
> +        bitbake("m4 -c compile -f")
>          self.addCleanup(bitbake, 'ccache-native -ccleansstate')
>          res = runCmd("grep ccache %s" %
> (os.path.join(get_bb_var("WORKDIR","m4"),"temp/log.do_compile")),
> ignore_status=True)
>          self.assertEqual(0, res.status, msg="No match for ccache in
> m4 log.do_compile. For further details: %s" %
> os.path.join(get_bb_var("WORKDIR","m4"),"temp/log.do_compile"))

If we force something like this we really need a cleanup in there to
remove the taint too...

Cheers,

Richard


  reply	other threads:[~2017-01-31 23:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-31 22:50 [PATCH 0/4] Some optimizations on top time selftest checks leonardo.sandoval.gonzalez
2017-01-31 22:50 ` [PATCH 1/4] selftest/buildoptions: use a thinner image to test 'read-only-rootfs' feature leonardo.sandoval.gonzalez
2017-01-31 23:16   ` Richard Purdie
2017-02-01 15:02     ` Leonardo Sandoval
2017-02-01 16:00       ` Richard Purdie
2017-02-01 16:13       ` Patrick Ohly
2017-02-02 12:40   ` Burton, Ross
2017-01-31 22:50 ` [PATCH 2/4] selftest/buildoptions: force compile task instead of cleaning sstates leonardo.sandoval.gonzalez
2017-01-31 23:16   ` Richard Purdie [this message]
2017-01-31 22:50 ` [PATCH 3/4] selftest/bbtests: use write_config instead of local.conf file leonardo.sandoval.gonzalez
2017-01-31 22:50 ` [PATCH 4/4] selftest/archiver: invalidate stamps instead of removing TMPDIR leonardo.sandoval.gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485904560.14144.18.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=leonardo.sandoval.gonzalez@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox