Re: [PATCH] libtasn1: depends on yacc

[Patrick Ohly <patrick.ohly@intel.com>]

On Wed, 2017-02-01 at 08:56 -0800, Khem Raj wrote:
> 
> On 1/31/17 1:05 AM, Patrick Ohly wrote:
> > This fixes a potential pollution by the build host and build error
> > when yacc isn't installed on the build host:
> > 
> >  | ../../libtasn1-4.9/build-aux/ylwrap: line 175: yacc: command not found
> >  | Makefile:1116: recipe for target 'ASN1.c' failed
> >  | make[3]: *** [ASN1.c] Error 127
> > 
> > Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
> > ---
> >  meta/recipes-support/gnutls/libtasn1_4.9.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/meta/recipes-support/gnutls/libtasn1_4.9.bb b/meta/recipes-support/gnutls/libtasn1_4.9.bb
> > index b8ff9eaf7a9..3da5d4bcc56 100644
> > --- a/meta/recipes-support/gnutls/libtasn1_4.9.bb
> > +++ b/meta/recipes-support/gnutls/libtasn1_4.9.bb
> > @@ -16,6 +16,8 @@ SRC_URI = "${GNU_MIRROR}/libtasn1/libtasn1-${PV}.tar.gz \
> >             file://0004-tools-eliminated-compiler-warnings.patch \
> >             "
> >  
> > +DEPENDS = "bison-native"
> > +
> 
> nit on style, you generally put checksum assignments immediately after
> SRC_URI containing the origninal src location. Secondly, if we use +=
> then we dont run the risk of it overwriting prior assignments if any

Makes sense, will change that as suggested.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.