From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Wold, Saul" <saul.wold@intel.com>,
"Sullivan, California L" <california.l.sullivan@intel.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] kernel.bbclass: Make sanity check opt-out and provide easy opt-out
Date: Wed, 15 Feb 2017 08:50:12 -0800 [thread overview]
Message-ID: <1487177412.27753.91.camel@linuxfoundation.org> (raw)
In-Reply-To: <1487139667.10318.32.camel@intel.com>
On Wed, 2017-02-15 at 06:21 +0000, Wold, Saul wrote:
> This should also be applied Morty please
Whilst we can likely do this in master, it does have side effects you
aren't highlighting. You're making the kernel version check default for
*all* kernels linux-yocto or otherwise. This is a significant change in
behaviour and could break many existing non linux-yocto recipes. That
is certainly not something which can easily be backported to morty. Its
also something which if intended, should be hightlighted in the commit
message.
This is a good example of why these "can we backport this?" messages
for changes that haven't even made master worry me.
Cheers,
Richard
next prev parent reply other threads:[~2017-02-15 16:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 23:55 [PATCH 1/1] kernel.bbclass: Make sanity check opt-out and provide easy opt-out California Sullivan
2017-02-15 6:21 ` Wold, Saul
2017-02-15 16:50 ` Richard Purdie [this message]
2017-02-23 22:32 ` [PATCH v2 " California Sullivan
2017-02-23 23:07 ` Burton, Ross
2017-02-23 23:27 ` Cal Sullivan
2017-02-24 0:13 ` Cal Sullivan
2017-02-24 18:19 ` Cal Sullivan
2017-02-28 1:02 ` [PATCH v3 1/1] kernel.bbclass: Give sanity check function an opt-out variable California Sullivan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487177412.27753.91.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=california.l.sullivan@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=saul.wold@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox