Re: [PATCHv2 1/1] insane.bbclass: Add missing dependencies

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2017-02-10 at 14:19 -0600, mariano.lopez@linux.intel.com wrote:
> From: Mariano Lopez <mariano.lopez@linux.intel.com>
> 
> package_qa task requires some tools installed in sysroot; with
> the introduction of recipe specific sysroot this task won't
> have such tools installed if it's forced to run.
> 
> Signed-off-by: Mariano Lopez <mariano.lopez@linux.intel.com>
> ---
>  meta/classes/insane.bbclass | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/insane.bbclass
> b/meta/classes/insane.bbclass
> index 3cf86c1..0167b14 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -1223,9 +1223,12 @@ python do_package_qa () {
>      bb.note("DONE with PACKAGE QA")
>  }
>  
> +# binutils is used for most checks, so need to set as dependency
> +# POPULATESYSROOTDEPS is defined in staging class.
> +do_package_qa[depends] += "${POPULATESYSROOTDEPS}"
>  do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
>  do_package_qa[rdeptask] = "do_packagedata"
> -addtask do_package_qa after do_packagedata do_package before
> do_build
> +addtask do_package_qa after do_prepare_recipe_sysroot do_packagedata
> do_package before do_build

This is close but I don't think you need this last addtask change, I
think it should work just fine with the added [depends]?

Cheers,

Richard