Re: [PATCH v2 3/3] rm_work.bbclass: Do not remove fetching and install_overlay stamps

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2017-02-15 at 18:33 +0100, Geoffrey Levillain wrote:
> In order to keep do_install_overlay to reexecute it's needed to keep
> stamps of fetching tasks.
> 
> Without that do_install_overlay would reexecute and do_image as well
> but
> do_image will crash since there is no rootfs.
> 
> Signed-off-by: Geoffrey Levillain <geoffrey.levillain@smile.fr>
> ---
>  meta/classes/rm_work.bbclass | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta/classes/rm_work.bbclass
> b/meta/classes/rm_work.bbclass
> index 054c93716e..c0e7c2a0a6 100644
> --- a/meta/classes/rm_work.bbclass
> +++ b/meta/classes/rm_work.bbclass
> @@ -71,6 +71,10 @@ do_rm_work () {
>                  i=dummy
>                  break
>                  ;;
> +            *do_fetch*|*do_unpack*|*do_patch*|*install_overlay*)
> +                i=dummy
> +                break
> +                ;;

This patch whitelists not just the install_overlay stamps but the
fetch, patch and unpack stamps for *everything* in all recipes? That
clearly isn't correct...

Cheers,

Richard