Re: [PATCH] busybox: setup "inetd" sub-package

[Sylvain Lemieux <slemieux.tyco@gmail.com>]

Hi Gary,

On Fri, 2017-02-17 at 04:56 +0100, Gary Thomas wrote:
> On 2017-02-16 21:47, Sylvain Lemieux wrote:
> > From: Sylvain Lemieux <slemieux@tycoint.com>
> >
> > Setup "inetd" as a sub-package in "busybox" and
> > add the support to install "inetd" as a startup script.
> >
> > Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> > ---
> >  meta/recipes-core/busybox/busybox.inc | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
> > index 39c2eef082..a26fa08ca8 100644
> > --- a/meta/recipes-core/busybox/busybox.inc
> > +++ b/meta/recipes-core/busybox/busybox.inc
> > @@ -21,7 +21,7 @@ export EXTRA_LDFLAGS = "${LDFLAGS}"
> >  # We don't want '-e MAKEFLAGS=' in EXTRA_OEMAKE
> >  EXTRA_OEMAKE = "CC='${CC}' LD='${CCLD}' V=1 ARCH=${TARGET_ARCH} CROSS_COMPILE=${TARGET_PREFIX} SKIP_STRIP=y"
> >
> > -PACKAGES =+ "${PN}-httpd ${PN}-udhcpd ${PN}-udhcpc ${PN}-syslog ${PN}-mdev ${PN}-hwclock"
> > +PACKAGES =+ "${PN}-httpd ${PN}-udhcpd ${PN}-udhcpc ${PN}-syslog ${PN}-mdev ${PN}-hwclock ${PN}-inetd"
> >
> >  FILES_${PN}-httpd = "${sysconfdir}/init.d/busybox-httpd /srv/www"
> >  FILES_${PN}-syslog = "${sysconfdir}/init.d/syslog* ${sysconfdir}/syslog-startup.conf* ${sysconfdir}/syslog.conf* ${systemd_unitdir}/system/syslog.service ${sysconfdir}/default/busybox-syslog"
> > @@ -29,8 +29,9 @@ FILES_${PN}-mdev = "${sysconfdir}/init.d/mdev ${sysconfdir}/mdev.conf ${sysconfd
> >  FILES_${PN}-udhcpd = "${sysconfdir}/init.d/busybox-udhcpd"
> >  FILES_${PN}-udhcpc = "${sysconfdir}/udhcpc.d ${datadir}/udhcpc"
> >  FILES_${PN}-hwclock = "${sysconfdir}/init.d/hwclock.sh"
> > +FILES_${PN}-inetd = "${sysconfdir}/init.d/inetd.${BPN} ${sysconfdir}/inetd.conf"
> >
> > -INITSCRIPT_PACKAGES = "${PN}-httpd ${PN}-syslog ${PN}-udhcpd ${PN}-mdev ${PN}-hwclock"
> > +INITSCRIPT_PACKAGES = "${PN}-httpd ${PN}-syslog ${PN}-udhcpd ${PN}-mdev ${PN}-hwclock ${PN}-inetd"
> >
> >  INITSCRIPT_NAME_${PN}-httpd = "busybox-httpd"
> >  INITSCRIPT_NAME_${PN}-hwclock = "hwclock.sh"
> > @@ -38,6 +39,7 @@ INITSCRIPT_NAME_${PN}-mdev = "mdev"
> >  INITSCRIPT_PARAMS_${PN}-mdev = "start 04 S ."
> >  INITSCRIPT_NAME_${PN}-syslog = "syslog"
> >  INITSCRIPT_NAME_${PN}-udhcpd = "busybox-udhcpd"
> > +INITSCRIPT_NAME_${PN}-inetd = "inetd.${BPN}"
> >
> >  SYSTEMD_PACKAGES = "${PN}-syslog"
> >  SYSTEMD_SERVICE_${PN}-syslog = "busybox-syslog.service"
> > @@ -45,7 +47,7 @@ SYSTEMD_SERVICE_${PN}-syslog = "busybox-syslog.service"
> >  CONFFILES_${PN}-syslog = "${sysconfdir}/syslog-startup.conf.${BPN}"
> >  CONFFILES_${PN}-mdev = "${sysconfdir}/mdev.conf"
> >
> > -RRECOMMENDS_${PN} = "${PN}-syslog ${PN}-udhcpc"
> > +RRECOMMENDS_${PN} = "${PN}-syslog ${PN}-udhcpc ${PN}-inetd"
> >
> >  inherit cml1 systemd update-rc.d ptest
> >
> >
> 
> Doesn't this patch conflict with your previous one adding the -cron sub-package?
> 
Yes this patch will not apply on top of the previous one.
I sent them this way, because both patch are independent.

If you prefer, I can send a v2 as a series.

Regards,
Sylvain
> 
> -- 
> ------------------------------------------------------------
> Gary Thomas                 |  Consulting for the
> MLB Associates              |    Embedded world
> ------------------------------------------------------------