From: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
To: Patrick Ohly <patrick.ohly@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] runqemu: avoid overridden user input for bootparams
Date: Tue, 28 Feb 2017 13:44:39 +0200 [thread overview]
Message-ID: <1488282279.3608.169.camel@linux.intel.com> (raw)
In-Reply-To: <1488279122.7785.34.camel@intel.com>
On Tue, 2017-02-28 at 11:52 +0100, Patrick Ohly wrote:
> On Tue, 2017-02-21 at 17:18 +0200, Dmitry Rozhkov wrote:
> >
> > Currently runqemu hardcodes the "ip=" kernel boot parameter
> > when configuring QEMU to use tap or slirp networking. This makes
> > the guest system to have a network interface pre-configured
> > by kernel and causes systemd to fail renaming the interface
> > to whatever pleases it:
> >
> > Feb 21 10:10:20 intel-corei7-64 systemd-udevd[201]: Error
> > changing
> > net interface name 'eth0' to 'enp0s3': Device or resource
> > busy,
> >
> > Always append user input for kernel boot params after the ones
> > added by the script. This way user input has priority over
> > runqemu's
> > default params.
>
> Presumably the user's bootparams then would include "ip="?
Yes, exactly that. "ip=" in the user's bootparams is the input that
shouldn't be ignored.
> Either way, the change looks good to me. I did something similar for
> the
> qemu parameters in "runqemu: let command line parameters override
> defaults".
>
BR,
Dmitry
prev parent reply other threads:[~2017-02-28 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 15:18 [PATCH] runqemu: avoid overridden user input for bootparams Dmitry Rozhkov
2017-02-28 10:52 ` Patrick Ohly
2017-02-28 11:44 ` Dmitry Rozhkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488282279.3608.169.camel@linux.intel.com \
--to=dmitry.rozhkov@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=patrick.ohly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox