From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id DD01677507 for ; Wed, 8 Mar 2017 18:00:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id v28I0ZqV006974; Wed, 8 Mar 2017 18:00:35 GMT Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id a7OZZJSN5bUd; Wed, 8 Mar 2017 18:00:35 +0000 (GMT) Received: from hex ([192.168.3.34]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id v28I0UwX006971 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 8 Mar 2017 18:00:31 GMT Message-ID: <1488996030.22968.78.camel@linuxfoundation.org> From: Richard Purdie To: "Burton, Ross" , Peter Kjellerstedt Date: Wed, 08 Mar 2017 18:00:30 +0000 In-Reply-To: References: X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 Mime-Version: 1.0 Cc: OE-core Subject: Re: [PATCHv3 0/5] Add dummy tools to help identify needed dependencies X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 18:00:41 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2017-03-08 at 17:21 +0000, Burton, Ross wrote: > > On 8 March 2017 at 09:43, Peter Kjellerstedt .com> wrote: > > since I see that you have integrated/staged the two patches that > > add > > inherits of pkgconfig, but not the patches that add the dummy > > commands, > > I assume you have some reservations to these patches. What are your > > take on the subject of blacklisting vs whitelisting the commands > > from > > the build host? I know that having these dummy commands in place > > helped > > me a great deal when updating our recipes to build correctly with > > RSS. > > > FWIW I wasn't entirely keen on how the blacklisting had to be very > careful about how PATH was manipulated, which is why I merged to my > staging branch the fixes but not the dummy commands. > > If the majority of people agree that this should be merged I don't > have a strong opinion either way. Ultimately I think there is a better solution than this but I haven't had time to look at that as yet. I do worry that it makes assumptions about PATH that may or may not be valid everywhere, equally I do see it could be useful. So I also have mixed feelings... Cheers, Richard