Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Patrick Ohly <patrick.ohly@intel.com>
To: Joshua Lock <joshua.g.lock@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/4] meta-selftest: add selftest-ed recipes
Date: Thu, 09 Mar 2017 21:05:50 +0100	[thread overview]
Message-ID: <1489089950.7785.374.camel@intel.com> (raw)
In-Reply-To: <20170308172417.15776-2-joshua.g.lock@intel.com>

On Wed, 2017-03-08 at 17:24 +0000, Joshua Lock wrote:
> The oe-selftest oescripts.TestScripts.test_cleanup_workdir was using
> gzip and the GPLv2 variant to test cleanup of the workdir. This broke
> with the removal of GPLv2 recipes from OE-Core.
> 
> Instead of relying on recipes in OE-Core remaining static we should
> ensure that meta-selftest provides recipes required for the tests to pass.
> To that end we take a copy of the current GPLv2 and GPLv3 variants of ed
> and include them in meta-selftest as new recipes.
> We chose ed over gzip as gzip has dependencies which would require
> additional GPLv2 recipes to be included in meta-selftest.

Wouldn't the test become faster when using artificial recipes, i.e.
something which doesn't really need sources? Such an artificial recipe
can use a local file as its "source", for example.

Or did I misunderstand something and the selftest doesn't really build
ed?

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.





  reply	other threads:[~2017-03-09 20:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 17:24 [PATCH 1/4] chkconfig-alternatives-native: fix obey_variables Joshua Lock
2017-03-08 17:24 ` [PATCH 2/4] meta-selftest: add selftest-ed recipes Joshua Lock
2017-03-09 20:05   ` Patrick Ohly [this message]
2017-03-10 13:27     ` Joshua Lock
2017-03-10 13:38       ` Patrick Ohly
2017-03-08 17:24 ` [PATCH 3/4] lib/oeqa/selftest/oescripts: make test_cleanup_workdir use selftest-ed Joshua Lock
2017-03-08 17:24 ` [PATCH 4/4] lib/oeqa/selftest/bbtests: update test_non_gplv3 to " Joshua Lock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489089950.7785.374.camel@intel.com \
    --to=patrick.ohly@intel.com \
    --cc=joshua.g.lock@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox