From: "Maxin B. John" <maxin.john@intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 2/2] valgrind: correct the comparison logic in vg_regtest
Date: Fri, 24 Mar 2017 17:03:20 +0200 [thread overview]
Message-ID: <1490367800-28099-3-git-send-email-maxin.john@intel.com> (raw)
In-Reply-To: <1490367800-28099-1-git-send-email-maxin.john@intel.com>
do_diffs in the vg_regtest script compares the actual test output
against the expected test output and returns 0 if it matches.
Previous upgrade modified the return value of do_diffs() and that
resulted in ptest failures.
[YOCTO #8471]
Signed-off-by: Maxin B. John <maxin.john@intel.com>
---
.../0005-Modify-vg_test-wrapper-to-support-PTEST-formats.patch | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-devtools/valgrind/valgrind/0005-Modify-vg_test-wrapper-to-support-PTEST-formats.patch b/meta/recipes-devtools/valgrind/valgrind/0005-Modify-vg_test-wrapper-to-support-PTEST-formats.patch
index f5ac989..7985308 100644
--- a/meta/recipes-devtools/valgrind/valgrind/0005-Modify-vg_test-wrapper-to-support-PTEST-formats.patch
+++ b/meta/recipes-devtools/valgrind/valgrind/0005-Modify-vg_test-wrapper-to-support-PTEST-formats.patch
@@ -100,7 +100,7 @@ index a441f42..cb05b52 100755
unlink("$name.$mid.out");
unlink(<$name.$mid.diff*>);
- return;
-+ return 1;
++ return 0;
}
}
}
@@ -113,7 +113,7 @@ index a441f42..cb05b52 100755
print "Failure encountered, stopping to loop\n";
exit 1
}
-+ return 0;
++ return 1;
}
sub do_one_test($$)
--
2.4.0
prev parent reply other threads:[~2017-03-24 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 15:03 [PATCH 0/2] fix valgrind ptest Maxin B. John
2017-03-24 15:03 ` [PATCH 1/2] valgrind: vg_regtest.in: fix perl script Maxin B. John
2017-03-24 15:03 ` Maxin B. John [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490367800-28099-3-git-send-email-maxin.john@intel.com \
--to=maxin.john@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox