Re: [PATCH] classes: Replace "if test" file tests with POSIX file tests

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sat, 2017-03-25 at 14:03 -0400, Robert P. J. Day wrote:
> In entire meta/classes/ directory, replace shell tests of the form
> "if test -? ..." with POSIX tests of the form "if [ -? ...
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 
> ---
> 
>   as i cannot abide those silly "if test" constructs, i zipped
> through
> and changed them to POSIX form. is there any objection to this kind
> of
> cleanup? next up ... all those "x${VAR} = x" tests ...

I've merged most of this. There were pieces of the diff that simply
didn't apply so I skipped them.

The reason I've taken what applied is that this is very expensive for
us to test right now and I made the most of the testing time I had on
the weekend. The issue is changes to the core classes rebuild
everything so we can't reuse sstate and the tests are much slower.

We're running late with M3 rc2 but just about to build it and I thought
it was worth getting some of this in rather none at all. Please do
figure out the remaining pieces and send them and we may or may not
tweak the remaining bits in M4.

Cheers,

Richard