Re: [PATCH 2/2] bitbake.conf: Add aws-cli support

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2017-03-28 at 13:40 +0200, Elizabeth 'pidge' Flanagan wrote:
> This commit adds aws-cli support to bitbake in order to support
> the s3 fetcher in bitbake.
> 
> Signed-off-by: Elizabeth 'pidge' Flanagan <pidge@toganlabs.com>
> ---
>  meta/conf/bitbake.conf | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index fa5445b..f21b8d3 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -458,8 +458,8 @@ HOSTTOOLS += " \
>      bash sh cut sed gcc ld git rm install which find xargs cat true mktemp \
>      grep tar gzip touch cp mv basename dirname tr getopt sort awk head tail \
>      mkdir patch uniq perl python chmod python3 ar strip expr ls make as \
> -    ranlib egrep echo chown cpio tee wc wget bzip2 stat date rmdir od diff \
> -    md5sum dd chrpath file pod2man gunzip python2.7 ln g++ [ false true \
> +    ranlib egrep echo chown cpio tee wc wget aws bzip2 stat date rmdir \
> +    od diff md5sum dd chrpath file pod2man gunzip python2.7 ln g++ [ false true \
>      uname test hostname nm objdump objcopy cmp printf env readlink gawk fgrep \
>      expand pwd sleep diffstat chgrp flock ldd strings rpcgen du makeinfo \
>      getconf mknod cpp readelf split \

Adding to HOSTTOOLS means *all* systems have to have this available
else the build fails. This for example would breaks all our
autobuilders. Past feature freeze point this tends to upset me a bit
even more than usual.

You want to add this to HOSTTOOLS_NONFATAL below.

Your patch also doesn't apply against master either.

Cheers,

Richard