From: Patrick Ohly <patrick.ohly@intel.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] classes: Replace "if test" file tests with POSIX file tests
Date: Tue, 28 Mar 2017 15:42:23 +0200 [thread overview]
Message-ID: <1490708543.6396.397.camel@intel.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1703280651250.4321@uk63952.mitel.com>
On Tue, 2017-03-28 at 06:54 -0400, Robert P. J. Day wrote:
> i'm fine with that, as long as it's officially POSIX. that also
> suggests the alternate tests:
>
> [ "${VAR}" ]
> [ ! "${VAR}" ]
I personally prefer this. ! instead of -z feels more consistent (when
not using the special "-n", let's also avoid the special "-z" and use
the more general "!" instead.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
next prev parent reply other threads:[~2017-03-28 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-25 18:03 [PATCH] classes: Replace "if test" file tests with POSIX file tests Robert P. J. Day
2017-03-25 18:32 ` ✗ patchtest: failure for " Patchwork
2017-03-27 13:31 ` [PATCH] " Richard Purdie
2017-03-28 9:56 ` Robert P. J. Day
2017-03-28 10:46 ` Peter Kjellerstedt
2017-03-28 10:54 ` Robert P. J. Day
2017-03-28 13:42 ` Patrick Ohly [this message]
2017-03-28 10:47 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490708543.6396.397.camel@intel.com \
--to=patrick.ohly@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.kjellerstedt@axis.com \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox