From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id 1FA7E77CB1 for ; Wed, 29 Mar 2017 10:24:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.15.2/8.15.2/Debian-3) with ESMTP id v2TAOXtv005740; Wed, 29 Mar 2017 11:24:33 +0100 Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 76dZRDg0e-CR; Wed, 29 Mar 2017 11:24:33 +0100 (BST) Received: from hex ([192.168.3.34]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id v2TAOTpN005735 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 29 Mar 2017 11:24:31 +0100 Message-ID: <1490783069.13980.307.camel@linuxfoundation.org> From: Richard Purdie To: Peter Bergin , openembedded-core@lists.openembedded.org Date: Wed, 29 Mar 2017 11:24:29 +0100 In-Reply-To: <2b16b764-38e0-4112-48b4-9e17cbe129c3@berginkonsult.se> References: <1490731726-14536-1-git-send-email-peter@berginkonsult.se> <1490742158.13980.296.camel@linuxfoundation.org> <2b16b764-38e0-4112-48b4-9e17cbe129c3@berginkonsult.se> X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 Mime-Version: 1.0 Subject: Re: [PATCH] busybox: move default config fragments to defconfig X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 10:24:34 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2017-03-29 at 10:16 +0200, Peter Bergin wrote: > On 2017-03-29 01:02, Richard Purdie wrote: > > > > On Tue, 2017-03-28 at 22:08 +0200, Peter Bergin wrote: > > > > > > Move config fragments that are unconditionally and always applied > > > to the configuration to the default defconfig file. This will > > > make it easier to provide your own defconfig file for your > > > target. > > > > > > The problem this commit will solve is that if you provide your > > > own > > > defconfig file for your target it will be tampered with by the > > > configuration fragments in SRC_URI. If you not want those > > > configurations in your own setup you have to modify SRC_URI > > > variable in your setup. As those confguration fragment was always > > > applied it is a better solution to have them in the default > > > defconfig file instead. > > This basically removes any standard feature grouping from being > > used in > > the base busybox recipe. I don't think this is something we want to > > encourage, I'd actually like to see more feature group usage. > > > > So we need to find some other way of solving your issue. > > > > Cheers, > > > > Richard > I agree that it is nice and encouraged to group configurations > together and make them selectable as a group. Also, in case its not apparent, you can work around this today by providing empty fragment files in your own layer. These would override the default ones in the main recipe if you set it up right. Cheers, Richard