Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Elizabeth 'pidge' Flanagan" <pidge@toganlabs.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] bitbake.conf: Add aws to HOSTTOOLS_NONFATAL
Date: Wed, 29 Mar 2017 11:32:13 +0100	[thread overview]
Message-ID: <1490783533.13980.313.camel@linuxfoundation.org> (raw)
In-Reply-To: <1490781608-1841-1-git-send-email-pidge@toganlabs.com>

On Wed, 2017-03-29 at 12:00 +0200, Elizabeth 'pidge' Flanagan wrote:
> This adds aws to HOSTTOOLS_NONFATAL in order to get the s3 fetcher
> working again. 

Cool on this bit although you just broke the sorting patch I just
merged under duress (I knew this would cause pain) :/.

> It also sets FETCHCMD_s3 for completions sake.

Please don't if we don't need it.

Note your patch and this description don't match (FETCHCMD_aws) so its
clearly not needed ;-).

Cheers,

Richard

> Signed-off-by: Elizabeth 'pidge' Flanagan <pidge@toganlabs.com>
> ---
>  meta/conf/bitbake.conf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 96a9ed9..bfa8dd8 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -469,7 +469,7 @@ HOSTTOOLS += " \
>  HOSTTOOLS += "ip ping ps scp ssh stty"
>  
>  # Link to these if present
> -HOSTTOOLS_NONFATAL += "ccache gcc-ar gpg ld.bfd ld.gold nc sftp
> socat sudo"
> +HOSTTOOLS_NONFATAL += "ccache gcc-ar gpg ld.bfd ld.gold nc sftp
> socat sudo aws"
>  
>  # Temporary add few more detected in bitbake world
>  HOSTTOOLS_NONFATAL += "join nl size yes zcat"
> @@ -640,6 +640,7 @@ FETCHCMD_cvs = "/usr/bin/env cvs"
>  FETCHCMD_wget = "/usr/bin/env wget -t 2 -T 30 -nv --passive-ftp --
> no-check-certificate"
>  FETCHCMD_bzr = "/usr/bin/env bzr"
>  FETCHCMD_hg = "/usr/bin/env hg"
> +FETCHCMD_aws = "/usr/bin/env aws"
>  
>  SRCDATE = "${DATE}"
>  SRCREV ??= "INVALID"
> -- 
> 1.9.1
> 


  reply	other threads:[~2017-03-29 10:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-29 10:00 [PATCH] bitbake.conf: Add aws to HOSTTOOLS_NONFATAL Elizabeth 'pidge' Flanagan
2017-03-29 10:32 ` Richard Purdie [this message]
2017-03-29 13:15   ` Beth 'pidge' Flanagan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490783533.13980.313.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=pidge@toganlabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox