[PATCH] bitbake.conf: Add aws to HOSTTOOLS_NONFATAL

[PATCH] bitbake.conf: Add aws to HOSTTOOLS_NONFATAL

[Elizabeth 'pidge' Flanagan]

This adds aws to HOSTTOOLS_NONFATAL in order to get the s3 fetcher
working again. It also sets FETCHCMD_s3 for completions sake.

Signed-off-by: Elizabeth 'pidge' Flanagan <pidge@toganlabs.com>
---
 meta/conf/bitbake.conf | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 96a9ed9..bfa8dd8 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -469,7 +469,7 @@ HOSTTOOLS += " \
 HOSTTOOLS += "ip ping ps scp ssh stty"
 
 # Link to these if present
-HOSTTOOLS_NONFATAL += "ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
+HOSTTOOLS_NONFATAL += "ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo aws"
 
 # Temporary add few more detected in bitbake world
 HOSTTOOLS_NONFATAL += "join nl size yes zcat"
@@ -640,6 +640,7 @@ FETCHCMD_cvs = "/usr/bin/env cvs"
 FETCHCMD_wget = "/usr/bin/env wget -t 2 -T 30 -nv --passive-ftp --no-check-certificate"
 FETCHCMD_bzr = "/usr/bin/env bzr"
 FETCHCMD_hg = "/usr/bin/env hg"
+FETCHCMD_aws = "/usr/bin/env aws"
 
 SRCDATE = "${DATE}"
 SRCREV ??= "INVALID"
-- 
1.9.1

Re: [PATCH] bitbake.conf: Add aws to HOSTTOOLS_NONFATAL

[Richard Purdie]

On Wed, 2017-03-29 at 12:00 +0200, Elizabeth 'pidge' Flanagan wrote:
> This adds aws to HOSTTOOLS_NONFATAL in order to get the s3 fetcher
> working again. 

Cool on this bit although you just broke the sorting patch I just
merged under duress (I knew this would cause pain) :/.

> It also sets FETCHCMD_s3 for completions sake.

Please don't if we don't need it.

Note your patch and this description don't match (FETCHCMD_aws) so its
clearly not needed ;-).

Cheers,

Richard

> Signed-off-by: Elizabeth 'pidge' Flanagan <pidge@toganlabs.com>
> ---
>  meta/conf/bitbake.conf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 96a9ed9..bfa8dd8 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -469,7 +469,7 @@ HOSTTOOLS += " \
>  HOSTTOOLS += "ip ping ps scp ssh stty"
>  
>  # Link to these if present
> -HOSTTOOLS_NONFATAL += "ccache gcc-ar gpg ld.bfd ld.gold nc sftp
> socat sudo"
> +HOSTTOOLS_NONFATAL += "ccache gcc-ar gpg ld.bfd ld.gold nc sftp
> socat sudo aws"
>  
>  # Temporary add few more detected in bitbake world
>  HOSTTOOLS_NONFATAL += "join nl size yes zcat"
> @@ -640,6 +640,7 @@ FETCHCMD_cvs = "/usr/bin/env cvs"
>  FETCHCMD_wget = "/usr/bin/env wget -t 2 -T 30 -nv --passive-ftp --
> no-check-certificate"
>  FETCHCMD_bzr = "/usr/bin/env bzr"
>  FETCHCMD_hg = "/usr/bin/env hg"
> +FETCHCMD_aws = "/usr/bin/env aws"
>  
>  SRCDATE = "${DATE}"
>  SRCREV ??= "INVALID"
> -- 
> 1.9.1
> 

Re: [PATCH] bitbake.conf: Add aws to HOSTTOOLS_NONFATAL

[Beth 'pidge' Flanagan]

On Wed, 2017-03-29 at 11:32 +0100, Richard Purdie wrote:
> On Wed, 2017-03-29 at 12:00 +0200, Elizabeth 'pidge' Flanagan wrote:
> > 
> > This adds aws to HOSTTOOLS_NONFATAL in order to get the s3 fetcher
> > working again. 
> Cool on this bit although you just broke the sorting patch I just
> merged under duress (I knew this would cause pain) :/.
> 

Ah, yes, I see that. I'll get it sorted right.

> > 
> > It also sets FETCHCMD_s3 for completions sake.
> Please don't if we don't need it.
> 
> Note your patch and this description don't match (FETCHCMD_aws) so
> its
> clearly not needed ;-).
> 

*facepalm*

> Cheers,
> 
> Richard
> 
> > 
> > Signed-off-by: Elizabeth 'pidge' Flanagan <pidge@toganlabs.com>
> > ---
> >  meta/conf/bitbake.conf | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index 96a9ed9..bfa8dd8 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -469,7 +469,7 @@ HOSTTOOLS += " \
> >  HOSTTOOLS += "ip ping ps scp ssh stty"
> >  
> >  # Link to these if present
> > -HOSTTOOLS_NONFATAL += "ccache gcc-ar gpg ld.bfd ld.gold nc sftp
> > socat sudo"
> > +HOSTTOOLS_NONFATAL += "ccache gcc-ar gpg ld.bfd ld.gold nc sftp
> > socat sudo aws"
> >  
> >  # Temporary add few more detected in bitbake world
> >  HOSTTOOLS_NONFATAL += "join nl size yes zcat"
> > @@ -640,6 +640,7 @@ FETCHCMD_cvs = "/usr/bin/env cvs"
> >  FETCHCMD_wget = "/usr/bin/env wget -t 2 -T 30 -nv --passive-ftp --
> > no-check-certificate"
> >  FETCHCMD_bzr = "/usr/bin/env bzr"
> >  FETCHCMD_hg = "/usr/bin/env hg"
> > +FETCHCMD_aws = "/usr/bin/env aws"
> >  
> >  SRCDATE = "${DATE}"
> >  SRCREV ??= "INVALID"
> > -- 
> > 1.9.1
> >