Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Tristan Van Berkom <tristan.vanberkom@codethink.co.uk>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH] libjpeg-turbo: fix build on aarch64 or non-intel build hosts
Date: Wed, 29 Mar 2017 21:11:33 +0900	[thread overview]
Message-ID: <1490789493.18519.18.camel@codethink.co.uk> (raw)

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

This is already filed in the appropriate bugzilla:
   https://bugzilla.yoctoproject.org/show_bug.cgi?id=11240

Just notifying the list as the custom goes...

libjpeg-turbo in recipes-graphics has an unconditional dependency on
nasm-native, which is intel specific and wont be provided on non intel
arches.

Attaching a patch which fixes this by only requiring nasm-native when
targeting intel architectures.

Cheers,
    -Tristan

[-- Attachment #2: 0001-libjpeg-turbo-Support-building-on-non-intel-targets.patch --]
[-- Type: text/x-patch, Size: 1531 bytes --]

From d76d57a148dd372ff26b9b902b7b79a4ddb5e7a2 Mon Sep 17 00:00:00 2001
From: Tristan Van Berkom <tristan.vanberkom@codethink.co.uk>
Date: Fri, 24 Mar 2017 15:37:36 +0000
Subject: [PATCH] libjpeg-turbo: Support building on non intel targets.

nasm is intel specific, however libjpeg-turbo is still desirable
on other architectures.

Without this patch, it would seem that nasm is built on an intel
host and then ignored when compiling libjpeg-turbo for an arm target,
however it has libjpeg-turbo requiring nasm be built when building
on an arm/aarch64 host.

This fixes the issue so that nasm-native is not required on the host
when building for an aarch64 target.
---
 meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.1.bb b/meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.1.bb
index 70d38f4a1a..a650d6af2d 100644
--- a/meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.1.bb
+++ b/meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.1.bb
@@ -7,7 +7,8 @@ LIC_FILES_CHKSUM = "file://cdjpeg.h;endline=13;md5=05bab7c7ad899d85bfba60da1a127
                     file://jpeglib.h;endline=16;md5=f67d70e547a2662c079781c72f877f72 \
                     file://djpeg.c;endline=11;md5=b90b6d2b4119f9e5807cd273f525d2af \
 "
-DEPENDS = "nasm-native"
+DEPENDS_append_x86-64 = " nasm-native"
+DEPENDS_append_x86    = " nasm-native"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BPN}-${PV}.tar.gz \
            file://fix-mips.patch"
-- 
2.11.0


             reply	other threads:[~2017-03-29 12:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-29 12:11 Tristan Van Berkom [this message]
2017-03-29 12:32 ` ✗ patchtest: failure for libjpeg-turbo: fix build on aarch64 or non-intel build hosts Patchwork
2017-03-30  1:44 ` [PATCH] " Andre McCurdy
2017-03-30  8:09   ` Maxin B. John
2017-03-30 11:21     ` Burton, Ross
2017-03-31  7:43       ` Tristan Van Berkom
2017-03-31  8:46         ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490789493.18519.18.camel@codethink.co.uk \
    --to=tristan.vanberkom@codethink.co.uk \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox