From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: liu.ming50@gmail.com, openembedded-core@lists.openembedded.org
Cc: Ming Liu <peter.x.liu@external.atlascopco.com>
Subject: Re: [PATCH] meta: define REAL_MULTIMACH_TARGET_SYS/SDKTARGETSYSROOT in bitbake.conf
Date: Thu, 30 Mar 2017 09:53:38 +0100 [thread overview]
Message-ID: <1490864018.13980.340.camel@linuxfoundation.org> (raw)
In-Reply-To: <1490860656-27448-1-git-send-email-liu.ming50@gmail.com>
On Thu, 2017-03-30 at 09:57 +0200, liu.ming50@gmail.com wrote:
> From: Ming Liu <peter.x.liu@external.atlascopco.com>
>
> REAL_MULTIMACH_TARGET_SYS is being defined and referred in several
> recipes, which is redundant and not easy to be overriden, and
> SDKTARGETSYSROOT is also defined in two recipes.
>
> So move their definitions to bitbake.conf.
>
> Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
> ---
> meta/classes/populate_sdk_base.bbclass | 6 ------
> meta/classes/toolchain-scripts.bbclass | 3 ---
> meta/conf/bitbake.conf | 2 ++
> meta/recipes-core/meta/meta-environment.bb | 3 ---
> 4 files changed, 2 insertions(+), 12 deletions(-)
To be honest, REAL_MULTIMACH_TARGET_SYS is a hack and I'd prefer to
find ways to remove the need for it (and perhaps the other MULTIMACH*
variables). I'd therefore prefer not to move this to bitbake.conf which
would give the impression its something we want to encourage (we
don't).
Cheers,
Richard
next prev parent reply other threads:[~2017-03-30 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 7:57 [PATCH] meta: define REAL_MULTIMACH_TARGET_SYS/SDKTARGETSYSROOT in bitbake.conf liu.ming50
2017-03-30 8:53 ` Richard Purdie [this message]
2017-03-30 15:34 ` Richard Purdie
2017-03-30 16:41 ` Ming Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490864018.13980.340.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=liu.ming50@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.x.liu@external.atlascopco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox