From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id AAF6377D3B for ; Thu, 30 Mar 2017 16:44:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.15.2/8.15.2/Debian-3) with ESMTP id v2UGi6KF023491; Thu, 30 Mar 2017 17:44:06 +0100 Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HQdhNEaAl29N; Thu, 30 Mar 2017 17:44:06 +0100 (BST) Received: from hex ([192.168.3.34]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id v2UGi4lk023485 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 30 Mar 2017 17:44:05 +0100 Message-ID: <1490892244.13980.368.camel@linuxfoundation.org> From: Richard Purdie To: Serhii Popovych , openembedded-core@lists.openembedded.org Date: Thu, 30 Mar 2017 17:44:04 +0100 In-Reply-To: <26091783c10f94213a0f4d41a1ff2295997ae23d.1490728921.git.spopovyc@cisco.com> References: <26091783c10f94213a0f4d41a1ff2295997ae23d.1490728921.git.spopovyc@cisco.com> X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 Mime-Version: 1.0 Cc: XE-Linux Subject: Re: [PATCH v3 1/2] autoconf: Adjust shebang lines to remove interpreter path hardcode X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 16:44:13 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Tue, 2017-03-28 at 19:25 +0000, Serhii Popovych wrote: > If build host perl (and other tools) is old and we use some kind > of toolchain to provide recent perl/python/etc to the OE build > we still locked to use build host perl due to hardcoded shebang > lines in autoconf scripts. > > Behaviour was observed with Enterprise Linux 6 and devtoolset > toolchain from SCL (Software Collections) used to provide recent > version of perl (not provided with default buildtools-tarball). > > Pass /usr/bin/env perl in ac_cv_path_PERL configuration variables > for class-native and class-nativesdk. Use patch to autoconf to > replace > -w option in shebang line with modern way to enable warnings on perl > (i.e. "use warnings"). > > Note that ac_cv_path_PERL must be valid perl interpreter path > since configure will check perl version and Flock implementation. > It is not possible currently to use nativeperl from native > sysroot because autoconf does not DE > OBPENDS on perl-native (and Typo above. > doing so fails due to circular dependencies). Only possible > solution is to overwrite shebangs with nativeperl somewhere at > do_install() and update RDEPENDS for class-native. Or add perl > symlinks to nativeperl in sysroot. > > For now it seems good to use perl found by /usr/bin/env from > autoconf-native. > > Also add RDEPENDS for class-nativesdk and add nativesdk-perl > to them. > > v3: Corrected Upstream-Status tag. > v2: Just realized that files in quilt directory (.pc) patched >     unnecessarily. Revision history should go under --- below. > Cc: XE-Linux > Signed-off-by: Serhii Popovych > --- >  meta/recipes-devtools/autoconf/autoconf.inc        |   7 +- >  ...tion-in-shebangs-with-modern-use-warnings.patch | 120 > +++++++++++++++++++++ >  meta/recipes-devtools/autoconf/autoconf_2.69.bb    |   1 + >  3 files changed, 127 insertions(+), 1 deletion(-) >  create mode 100644 meta/recipes-devtools/autoconf/autoconf/autoconf- > replace-w-option-in-shebangs-with-modern-use-warnings.patch > > diff --git a/meta/recipes-devtools/autoconf/autoconf.inc > b/meta/recipes-devtools/autoconf/autoconf.inc > index b4e3356..408c5c9 100644 > --- a/meta/recipes-devtools/autoconf/autoconf.inc > +++ b/meta/recipes-devtools/autoconf/autoconf.inc > @@ -27,13 +27,18 @@ RDEPENDS_${PN} = "m4 gnu-config \ >     perl-module-data-dumper \ >    " >  RDEPENDS_${PN}_class-native = "m4-native gnu-config-native" > +RDEPENDS_${PN}_class-nativesdk = "nativesdk-m4 nativesdk-gnu-config > nativesdk-perl" This RDEPENDS change is not mentioned in the commit message. Does this mean we suddenly start including perl in our SDKs or buildtools tarballs? This should be a separate patch an include impact information if you're really proposing this. Cheers, Richard