From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Serhii Popovych <spopovyc@cisco.com>,
openembedded-core@lists.openembedded.org
Cc: XE-Linux <xe-linux-external@cisco.com>
Subject: Re: [PATCH v2 2/2] automake: Adjust shebang lines to remove interpreter path hardcode
Date: Thu, 30 Mar 2017 17:45:03 +0100 [thread overview]
Message-ID: <1490892303.13980.369.camel@linuxfoundation.org> (raw)
In-Reply-To: <e5e8a9eba45b85ef30e6fcdf6276476da0d384b6.1490728922.git.spopovyc@cisco.com>
On Tue, 2017-03-28 at 19:25 +0000, Serhii Popovych wrote:
> If build host perl (and other tools) is old and we use some kind
> of toolchain to provide recent perl/python/etc to the OE build
> we still locked to use build host perl due to hardcoded shebang
> lines in automake scripts.
>
> Behaviour was observed with Enterprise Linux 6 and devtoolset
> toolchain from SCL (Software Collections) used to provide recent
> version of perl (not provided with default buildtools-tarball).
>
> Pass /usr/bin/env perl in ac_cv_path_PERL configuration variables
> for class-native and class-nativesdk. Use patch to automake to
> replace
> -w option in shebang line with modern way to enable warnings on perl
> (i.e. "use warnings").
>
> Note that ac_cv_path_PERL must be valid perl interpreter path
> since configure will check perl version and Flock implementation.
> It is not possible currently to use nativeperl from native
> sysroot because automake does not DEPENDS on perl-native (and
> doing so fails due to circular dependencies). Only possible
> solution is to overwrite shebangs with nativeperl somewhere at
> do_install() and update RDEPENDS for class-native. Or add perl
> symlinks to nativeperl in sysroot.
>
> For now it seems good to use perl found by /usr/bin/env from
> automake-native.
>
> Also add RDEPENDS for class-nativesdk and add nativesdk-perl to
> them.
>
> v2: Corrected Upstream-Status tag.
>
> Cc: XE-Linux <xe-linux-external@cisco.com>
> Signed-off-by: Serhii Popovych <spopovyc@cisco.com>
Again, the patch description and what it actually does don't match
(RDEPENDS)...
Cheers,
Richard
next prev parent reply other threads:[~2017-03-30 16:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 18:26 [PATCH 0/2] automake/autoconf: avoid path to perl interpreter hardcoding Serhii Popovych
2017-03-28 18:26 ` [PATCH 1/2] autoconf: Adjust shebang lines to remove interpreter path hardcode Serhii Popovych
2017-03-28 18:40 ` [PATCH v2 2/2] " Serhii Popovych
2017-03-28 18:26 ` [PATCH 2/2] automake: " Serhii Popovych
2017-03-28 19:02 ` ✗ patchtest: failure for automake/autoconf: avoid path to perl interpreter hardcoding Patchwork
2017-03-28 19:02 ` ✗ patchtest: failure for automake/autoconf: avoid path to perl interpreter hardcoding (rev2) Patchwork
2017-03-28 19:25 ` [PATCH v2 0/2] automake/autoconf: avoid path to perl interpreter hardcoding Serhii Popovych
2017-03-28 19:25 ` [PATCH v3 1/2] autoconf: Adjust shebang lines to remove interpreter path hardcode Serhii Popovych
2017-03-30 16:44 ` Richard Purdie
2017-03-31 11:46 ` [PATCH v3 0/2] automake/autoconf: avoid path to perl interpreter hardcoding Serhii Popovych
2017-03-31 11:46 ` [PATCH v4 1/2] autoconf: Adjust shebang lines to remove interpreter path hardcode Serhii Popovych
2017-03-31 11:46 ` [PATCH v3 2/2] automake: " Serhii Popovych
2017-03-28 19:25 ` [PATCH v2 " Serhii Popovych
2017-03-30 16:45 ` Richard Purdie [this message]
2017-03-31 12:02 ` ✗ patchtest: failure for "[v3,1/2] autoconf: Adjust sheb..." and 1 more (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490892303.13980.369.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=spopovyc@cisco.com \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox