Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] qemu arm/x86: drop linux-yocto preferred version
Date: Wed, 05 Apr 2017 23:41:12 +0100	[thread overview]
Message-ID: <1491432072.17200.26.camel@linuxfoundation.org> (raw)
In-Reply-To: <CADkTA4M3=Tk7J51LHieVsrkwR38wrYWXvMiC-QiFa5aT+xa+Ag@mail.gmail.com>

On Thu, 2017-04-06 at 00:33 +0200, Bruce Ashfield wrote:
> On Wed, Apr 5, 2017 at 3:21 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > 
> > > @@ -16,5 +16,4 @@ QB_MACHINE = "-machine versatilepb"
> > >  QB_KERNEL_CMDLINE_APPEND = "console=ttyAMA0,115200 console=tty"
> > >  # Add the 'virtio-rng-pci' device otherwise the guest may run
> > out of entropy
> > >  QB_OPT_APPEND = "-show-cursor -usb -usbdevice tablet -device
> > virtio-rng-pci"
> > > -PREFERRED_VERSION_linux-yocto ??= "4.8%"
> > >  QB_DTB = "${@base_version_less_or_equal('PREFERRED_VERSION_linux
> > -yocto', '4.7', '', 'zImage-versatile-pb.dtb', d)}"
> > 
> > Note the line below the line you're removing here. This is why we  
> > need
> > this one...
> I had noticed that, but since the newest version is well above that,
> I figured it would be ok.

An unset variable returns "None", not sure
what base_version_less_or_equal makes of that...

> I can spin another patch that leaves it in place for ARM, but drops
> it for x86.

I took Martin's patch moving things to 4.10, quite happy to take a
second one removing the x86 version. Removing the arm one too would be
nice but I'm not sure we can yet.

Cheers,

Richard


  reply	other threads:[~2017-04-05 22:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 12:39 [PATCH] qemu arm/x86: drop linux-yocto preferred version Bruce Ashfield
2017-04-05 13:21 ` Richard Purdie
2017-04-05 22:33   ` Bruce Ashfield
2017-04-05 22:41     ` Richard Purdie [this message]
2017-04-05 22:49       ` Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491432072.17200.26.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bruce.ashfield@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox