[PATCH] selftest/recipetool: skip create_git in case x11 feature is not present

[PATCH] selftest/recipetool: skip create_git in case x11 feature is not present

[leonardo.sandoval.gonzalez]

From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>

The unit test requires x11 as distro feature, otherwise it will fail
while building the test requirements.

[YOCTO #10903]

Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
 meta/lib/oeqa/selftest/recipetool.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/lib/oeqa/selftest/recipetool.py b/meta/lib/oeqa/selftest/recipetool.py
index d47b9dd..7bfb02f 100644
--- a/meta/lib/oeqa/selftest/recipetool.py
+++ b/meta/lib/oeqa/selftest/recipetool.py
@@ -382,6 +382,8 @@ class RecipetoolTests(RecipetoolBase):
 
     @testcase(1194)
     def test_recipetool_create_git(self):
+        if 'x11' not in get_bb_var('DISTRO_FEATURES'):
+            self.skipTest('Test requires x11 as distro feature')
         # Ensure we have the right data in shlibs/pkgdata
         bitbake('libpng pango libx11 libxext jpeg libcheck')
         # Try adding a recipe
-- 
2.10.2

Re: [PATCH] selftest/recipetool: skip create_git in case x11 feature is not present

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]

On 6 April 2017 at 19:41, <leonardo.sandoval.gonzalez@linux.intel.com>
wrote:

> From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
>
> The unit test requires x11 as distro feature, otherwise it will fail
> while building the test requirements.
>

How about changing the test recipe to something non-x11 instead?


>
> [YOCTO #10903]
>
> Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@
> linux.intel.com>
> ---
>  meta/lib/oeqa/selftest/recipetool.py | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/lib/oeqa/selftest/recipetool.py
> b/meta/lib/oeqa/selftest/recipetool.py
> index d47b9dd..7bfb02f 100644
> --- a/meta/lib/oeqa/selftest/recipetool.py
> +++ b/meta/lib/oeqa/selftest/recipetool.py
> @@ -382,6 +382,8 @@ class RecipetoolTests(RecipetoolBase):
>
>      @testcase(1194)
>      def test_recipetool_create_git(self):
> +        if 'x11' not in get_bb_var('DISTRO_FEATURES'):
> +            self.skipTest('Test requires x11 as distro feature')
>          # Ensure we have the right data in shlibs/pkgdata
>          bitbake('libpng pango libx11 libxext jpeg libcheck')
>          # Try adding a recipe
> --
> 2.10.2
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2444 bytes --]

Re: [PATCH] selftest/recipetool: skip create_git in case x11 feature is not present

[Leonardo Sandoval]

On Fri, 2017-04-07 at 08:57 +0300, Jussi Kukkonen wrote:
> 
> 
> On 6 April 2017 at 19:41, <leonardo.sandoval.gonzalez@linux.intel.com>
> wrote:
>         From: Leonardo Sandoval
>         <leonardo.sandoval.gonzalez@linux.intel.com>
>         
>         The unit test requires x11 as distro feature, otherwise it
>         will fail
>         while building the test requirements.
> 
> 
> How about changing the test recipe to something non-x11 instead?
>  

Yes, but at this point of the release, I do not think it is a good idea.
There was another case on the devtool's selftest where the target was
quite complex for a poky-tiny distro, but again, it requires time to
redo the test and this is not the perfect time frame.

>         
>         [YOCTO #10903]
>         
>         Signed-off-by: Leonardo Sandoval
>         <leonardo.sandoval.gonzalez@linux.intel.com>
>         ---
>          meta/lib/oeqa/selftest/recipetool.py | 2 ++
>          1 file changed, 2 insertions(+)
>         
>         diff --git a/meta/lib/oeqa/selftest/recipetool.py
>         b/meta/lib/oeqa/selftest/recipetool.py
>         index d47b9dd..7bfb02f 100644
>         --- a/meta/lib/oeqa/selftest/recipetool.py
>         +++ b/meta/lib/oeqa/selftest/recipetool.py
>         @@ -382,6 +382,8 @@ class RecipetoolTests(RecipetoolBase):
>         
>              @testcase(1194)
>              def test_recipetool_create_git(self):
>         +        if 'x11' not in get_bb_var('DISTRO_FEATURES'):
>         +            self.skipTest('Test requires x11 as distro
>         feature')
>                  # Ensure we have the right data in shlibs/pkgdata
>                  bitbake('libpng pango libx11 libxext jpeg libcheck')
>                  # Try adding a recipe
>         --
>         2.10.2
>         
>         --
>         _______________________________________________
>         Openembedded-core mailing list
>         Openembedded-core@lists.openembedded.org
>         http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
>