Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Burton, Ross" <ross.burton@intel.com>,
	Rebecca Chang Swee Fun <rebecca.swee.fun.chang@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] ghostscript: separate objarch.h based on architecture
Date: Thu, 13 Apr 2017 17:23:10 +0100	[thread overview]
Message-ID: <1492100590.19076.5.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAJTo0LYjwh8KD-h+gXpVkqm4utT6i2_TBZdEaTCeLF5xN_cm3Q@mail.gmail.com>

On Thu, 2017-04-13 at 15:06 +0100, Burton, Ross wrote:
> 
> On 13 April 2017 at 10:11, Rebecca Chang Swee Fun <rebecca.swee.fun.c
> hang@intel.com> wrote:
> > +ARCHFILE ?= ""
> > +
> > +ARCHFILE_aarch64 = "file://objarch.h"
> > +
> > +ARCHFILE_arm = "file://objarch.h"
> > +
> > +ARCHFILE_armeb = "file://objarch.h"
> > +
> > +ARCHFILE_i586 = "file://objarch.h"
> > +
> > +ARCHFILE_i686 = "file://objarch.h"
> > +
> > +ARCHFILE_microblazeeb = "file://objarch.h"
> > +
> > +ARCHFILE_microblazeel = "file://objarch.h"
> > +
> > +ARCHFILE_mipsarchn32eb = "file://objarch.h"
> > +
> > +ARCHFILE_mipsarchn32el = "file://objarch.h"
> > +
> > +ARCHFILE_mipsarchn64eb = "file://objarch.h"
> > +
> > +ARCHFILE_mipsarchn64el = "file://objarch.h"
> > +
> > +ARCHFILE_mipsarcho32eb = "file://objarch.h"
> > +
> > +ARCHFILE_mipsarcho32el = "file://objarch.h"
> > +
> > +ARCHFILE_nios2 = "file://objarch.h"
> > +
> > +ARCHFILE_powerpc = "file://objarch.h"
> > +
> > +ARCHFILE_powerpc64 = "file://objarch.h"
> > +
> > +ARCHFILE_x86-64 = "file://objarch.h"
> > 
> That's a very long list, would it be easier to set it to objarch.h
> and then use select overrides to clear it?

Its basically copying the structure from the disk which we don't want
to do.

I think what this recipe needs to do is raise a SkipRecipe exception if
it not one of the supported architectures. This would then only display
an error if someone specifically tries to build the recipe.

Cheers,

Richard


      reply	other threads:[~2017-04-13 16:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-13  9:11 [PATCH] ghostscript: separate objarch.h based on architecture Rebecca Chang Swee Fun
2017-04-13 14:06 ` Burton, Ross
2017-04-13 16:23   ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492100590.19076.5.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=rebecca.swee.fun.chang@intel.com \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox