Re: [PATCH 0/2] Handle the hossttools directory when restoring from the sstate cache

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2017-04-28 at 17:01 +0200, Peter Kjellerstedt wrote:
> After the introduction of copying host tools to the build directory
> and cleaning out $PATH, we got a problem with one of our tools. It
> turned out that its configure.ac uses AC_PATH_PROG(PERL, perl) to
> locate the perl interpreter, and uses that on the shebang line of the
> installed tool. Previously it found /usr/bin/perl and used that, but
> now it will find ${TMPDIR}/hosttools/perl and use that instead, which
> means that if the tool is restored from the sstate cache in another
> build directory than where it originated from, the path will be
> wrong.
> 
> These two patches adds a new variable (HOSTTOOLS_DIR) for the
> ${TMPDIR}/hosttools directory, and then makes sure it is handled by
> the staging code so that any references to its value are properly
> corrected when restoring from the sstate cache.

I did mention on irc that I didn't really want to do this, I only
wanted to fix this issue on a case by case basis.

The reason is that we currently have pretty clean sstate files in this
regard, we haven't needed to do this. If we add this, we'll become
reliant on the fixups. The fixups are slow and ideally we want to pass
in correct paths in the first place if/as/where we can.

So is there a way we can only do this if/as/where needed instead of
universally?

The performance overhead of fixups verses no fixups is significant.

Cheers,

Richard