[PATCH] manpages.bbclass: avoid QA warning when "manpages" feature not supported

[PATCH] manpages.bbclass: avoid QA warning when "manpages" feature not supported

[Patrick Ohly]

Activating API documentation with:
  INHERIT += "manpages"
  DISTRO_FEATURES_append = " api-documentation"
triggers QA warnings for each recipe which doesn't have a "manpages"
PACKAGECONFIG. Example:
  WARNING: base-files-3.0.14-r89 do_configure: QA Issue: base-files: invalid PACKAGECONFIG: manpages [invalid-packageconfig]

We need to be more selective when adding the "manpages" feature and check
whether it's supported first.

Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
---
 meta/classes/manpages.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/classes/manpages.bbclass b/meta/classes/manpages.bbclass
index d16237b..5aa1d1a 100644
--- a/meta/classes/manpages.bbclass
+++ b/meta/classes/manpages.bbclass
@@ -2,4 +2,5 @@
 # depending on whether 'api-documentation' is in DISTRO_FEATURES. Such building
 # tends to pull in the entire XML stack and other tools, so it's not enabled
 # by default.
-PACKAGECONFIG_append_class-target = " ${@bb.utils.contains('DISTRO_FEATURES', 'api-documentation', 'manpages', '', d)}"
+PACKAGECONFIG_append_class-target = "${@ '' if 'manpages' not in d.getVarFlags('PACKAGECONFIG') else \
+    bb.utils.contains('DISTRO_FEATURES', 'api-documentation', ' manpages', '', d)}"

base-commit: c59fa3bd71b42410bf032846ee8fdb6e6eb1b95c
-- 
git-series 0.9.1

Re: [PATCH] manpages.bbclass: avoid QA warning when "manpages" feature not supported

[Alexander Kanavin]

On 05/15/2017 11:32 AM, Patrick Ohly wrote:
> Activating API documentation with:
>   INHERIT += "manpages"
>   DISTRO_FEATURES_append = " api-documentation"

You do not need to add the first line at all, why are you doing it?

manpages is inherited on a per-recipe basis when the recipe itself 
supports the manpages PACKAGECONFIG. This patch is unnecessary.

Alex

Re: [PATCH] manpages.bbclass: avoid QA warning when "manpages" feature not supported

[Patrick Ohly]

On Mon, 2017-05-15 at 14:47 +0300, Alexander Kanavin wrote:
> On 05/15/2017 11:32 AM, Patrick Ohly wrote:
> > Activating API documentation with:
> >   INHERIT += "manpages"
> >   DISTRO_FEATURES_append = " api-documentation"
> 
> You do not need to add the first line at all, why are you doing it?

I thought that was how the class was meant to be used. "Inherit this
class" in manpages.bbclass is ambiguous.

> manpages is inherited on a per-recipe basis when the recipe itself 
> supports the manpages PACKAGECONFIG.

Now it starts to make sense...

>  This patch is unnecessary.

Agreed.

Patchwork-Status: Rejected

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.

Re: [PATCH] manpages.bbclass: avoid QA warning when "manpages" feature not supported

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

Hi Jose,

On 15 May 2017 at 13:24, Patrick Ohly <patrick.ohly@intel.com> wrote:

> Patchwork-Status: Rejected
>

The patch in patchworks hasn't been updated (
https://patchwork.openembedded.org/series/6723/), I thought patchworks was
listening for these commands now?

Ross

[-- Attachment #2: Type: text/html, Size: 862 bytes --]

Re: [PATCH] manpages.bbclass: avoid QA warning when "manpages" feature not supported

[Jose Lamego]

[-- Attachment #1.1: Type: text/plain, Size: 714 bytes --]



On 05/15/2017 08:06 AM, Burton, Ross wrote:
> Hi Jose,
> 
> On 15 May 2017 at 13:24, Patrick Ohly <patrick.ohly@intel.com
> <mailto:patrick.ohly@intel.com>> wrote:
> 
>     Patchwork-Status: Rejected
> 
> 
> The patch in patchworks hasn't been updated
> (https://patchwork.openembedded.org/series/6723/), I thought patchworks
> was listening for these commands now?

Sorry is miss this message.

The command line is missing the squared brackets (the following should
do the work since I may have permissions):

[Patchwork-Status: Rejected]

Guys: Do you believe we should drop the brackets requirement?

> 
> Ross 
> 
> 


-- 
Jose Lamego | OTC Embedded Platforms & Tools | GDC


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: [PATCH] manpages.bbclass: avoid QA warning when "manpages" feature not supported

[Jose Lamego]

[-- Attachment #1.1: Type: text/plain, Size: 165 bytes --]

Evidently, I don't have the required permissions (you can see the
previous system-generated comment).

-- 
Jose Lamego | OTC Embedded Platforms & Tools | GDC


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: [PATCH] manpages.bbclass: avoid QA warning when "manpages" feature not supported

[Alexander Kanavin]

On 05/24/2017 11:54 PM, Jose Lamego wrote:
> Sorry is miss this message.
>
> The command line is missing the squared brackets (the following should
> do the work since I may have permissions):
>
> [Patchwork-Status: Rejected]
>
> Guys: Do you believe we should drop the brackets requirement?

You can support both brackets and no-brackets.

The problem is that this feature is not documented, nobody knows about 
it, and we lack established practices around it. Who should be using it? 
I'd say only the author of the patch or people with commit rights to 
master (RP, Ross).

Alex

Re: [PATCH] manpages.bbclass: avoid QA warning when "manpages" feature not supported

[Jose Lamego]

[-- Attachment #1.1: Type: text/plain, Size: 870 bytes --]



On 05/25/2017 03:06 AM, Alexander Kanavin wrote:
> On 05/24/2017 11:54 PM, Jose Lamego wrote:
>> Sorry is miss this message.
>>
>> The command line is missing the squared brackets (the following should
>> do the work since I may have permissions):
>>
>> [Patchwork-Status: Rejected]
>>
>> Guys: Do you believe we should drop the brackets requirement?
> 
> You can support both brackets and no-brackets.
> 
> The problem is that this feature is not documented, nobody knows about
> it, and we lack established practices around it. Who should be using it?
> I'd say only the author of the patch or people with commit rights to
> master (RP, Ross).

I've added an entry to the OE-Patchwork wiki:

https://www.openembedded.org/wiki/Patchwork#Update_the_state_of_patches

> 
> Alex
> 

-- 
Jose Lamego | OTC Embedded Platforms & Tools | GDC


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]