Re: [PATCH] autogen: fix autoopts script generation to handle shebang

["Belal, Awais" <Awais_Belal@mentor.com>]

Hi Alex,

> The first line will guarantee a short shebang, while the second one may
> result in a very long shebang which may hit the hardcoded kernel limit.

I do not see how the second one can be longer in any case than the first one but that's probably because of my lack of knowledge. I can confirm that the changes around perl setting are not required and I only stepped over it because I was using an older commit of core however the change for sh is still required. Should I submit a v2 with that change only or is there a concern around that as well?

BR,
Awais

________________________________________
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
Sent: Monday, May 15, 2017 4:53 PM
To: Belal, Awais; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] autogen: fix autoopts script generation to handle shebang

On 05/15/2017 12:01 PM, Belal, Awais wrote:

> Really did not get the first question. Regarding PERL being set
> twice, I am just trying to manipulate it to the actual host binary,
> is there a better way? 'which perl' or 'env perl' will only point to
> the symlink under HOSTTOOLS.


1. You are replacing

#!/usr/bin/env perl

with

#! <result of calling `readlink -f ${PERL}`>

The first line will guarantee a short shebang, while the second one may
result in a very long shebang which may hit the hardcoded kernel limit.
So you are effectively adding the problem instead of fixing it (and
there is nothing to be fixed).

2. You do this:

PERL=`which perl`
PERL=`readlink -f ${PERL}`

There is no need for the first line, if PERL is immediately set to
something else.


Alex