From: Patrick Ohly <patrick.ohly@intel.com>
To: Alexander Kanavin <alexander.kanavin@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [RFC][PATCH 0/6] development vs. production builds
Date: Tue, 16 May 2017 16:25:34 +0200 [thread overview]
Message-ID: <1494944734.28624.19.camel@intel.com> (raw)
In-Reply-To: <4da20a5f-4d38-e3fb-b31e-f42ce8505564@linux.intel.com>
On Tue, 2017-05-16 at 17:02 +0300, Alexander Kanavin wrote:
> On 05/16/2017 04:47 PM, Patrick Ohly wrote:
>
> > Then why is not already done like that in practice? Is it just because
> > OE-core and Poky set such a bad precedence with teaching developers to
> > add EXTRA_IMAGE_FEATURES ?= "debug-tweaks" to make the images usable,
> > and then that approach gets copied?
>
> It is done like that already, it's just not very consistent from what I
> can see. For example, core-image-sato-dev.bb:
> =============
> require core-image-sato.bb
>
> DESCRIPTION = "Image with Sato for development work. It includes
> everything \
> within core-image-sato plus a native toolchain, application development
> and \
> testing libraries, profiling and debug symbols."
>
> IMAGE_FEATURES += "dev-pkgs"
> =============
That's different. Here an image recipe specifies what it is meant to
*contain*, not how it is meant to *behave*.
One would need core-image-sato-dev-production.bb (no debug-tweaks,
dev-pkgs), core-image-sato-dev-debug.bb (debug-tweaks, dev-pkgs),
core-image-sato-production.bb (no debug-tweaks, no dev-pkgs),
core-image-sato-debug.bb (debug-tweaks, no dev-pkgs).
Allowing EXTRA_IMAGE_FEATURES in local.conf.sample avoids that.
> I'm not a big fan of placing INHERIT into local.conf either, by the way.
> I believe in functional programming principles, and this goes directly
> against them.
It makes sense to me when the functionality is orthogonal to the
content, like enabling buildhistory.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
next prev parent reply other threads:[~2017-05-16 14:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 13:26 [RFC][PATCH 0/6] development vs. production builds Patrick Ohly
2017-05-15 13:26 ` [RFC][PATCH 1/6] build-mode.bbclass: distro-wide debug-build mode Patrick Ohly
2017-05-15 13:26 ` [RFC][PATCH 2/6] basefiles: warn about non-production DISTRO_FEATURES in motd Patrick Ohly
2017-05-15 13:27 ` [RFC][PATCH 3/6] defaultsetup.conf: enable special "debug-build" DISTRO_FEATURES support Patrick Ohly
2017-05-15 13:27 ` [RFC][PATCH 4/6] image-mode.bbclass: per-image production/development/debug mode Patrick Ohly
2017-05-15 13:27 ` [RFC][PATCH 5/6] image.bbclass: include IMAGE_MODE support Patrick Ohly
2017-05-15 13:27 ` [RFC][PATCH 6/6] local.conf.sample: make debug-tweaks depend on IMAGE_MODE Patrick Ohly
2017-05-15 15:50 ` Khem Raj
2017-05-15 19:18 ` Patrick Ohly
2017-05-15 19:34 ` Khem Raj
2017-05-15 19:47 ` Patrick Ohly
2017-05-15 20:25 ` Khem Raj
2017-05-16 6:26 ` Patrick Ohly
2017-05-16 7:12 ` Patrick Ohly
2017-05-16 7:29 ` [RFC][PATCH 0/6] development vs. production builds Richard Purdie
2017-05-16 8:17 ` Patrick Ohly
2017-05-17 7:58 ` [PATCH v2 0/1] " Patrick Ohly
2017-05-17 7:58 ` [PATCH v2 1/1] image-mode.bbclass: common infrastructure for choosing image defaults Patrick Ohly
2017-05-17 8:38 ` Patrick Ohly
2017-05-17 9:49 ` Alexander Kanavin
2017-05-17 10:47 ` Patrick Ohly
2017-05-17 12:56 ` Alexander Kanavin
2017-05-17 13:39 ` Patrick Ohly
2017-05-17 14:17 ` Alexander Kanavin
2017-05-16 7:35 ` [RFC][PATCH 0/6] development vs. production builds Mike Looijmans
2017-05-16 8:21 ` Patrick Ohly
2017-05-16 11:49 ` Alexander Kanavin
2017-05-16 13:47 ` Patrick Ohly
2017-05-16 14:02 ` Alexander Kanavin
2017-05-16 14:25 ` Patrick Ohly [this message]
2017-05-16 16:27 ` Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494944734.28624.19.camel@intel.com \
--to=patrick.ohly@intel.com \
--cc=alexander.kanavin@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox