Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
To: "Erik Botö" <erik.boto@pelagicore.com>
Cc: "Cetola, Stephano" <stephano.cetola@intel.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/4] masterimage.py: fix issue with calling reboot on masterimage/DUT
Date: Fri, 26 May 2017 08:57:27 -0500	[thread overview]
Message-ID: <1495807047.26945.19.camel@linux.intel.com> (raw)
In-Reply-To: <b41949aa-b992-6403-4b27-c54d22c15279@pelagicore.com>

On Fri, 2017-05-26 at 11:01 +0200, Erik Botö wrote:
> I guess an introduction should have been added to this patchset, so here 
> it comes a bit late:
> 

no problem, in that case, you may need to tag the commit(s) with the
bugzilla ID


> These patches are what I needed to do in order to get automated runtime 
> tests on target using the systemd-boot target working. There is an open 
> bug in the bugzilla for this as well: 
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=11524.
> 
> Cheers,
> Erik
> 
> 
> On 05/19/2017 04:20 PM, Erik Botö wrote:
> > On systemd systems calling reboot over an ssh connection doesn't
> > return as expected causing an exception, therefore wrap the call
> > to reboot in order to avoid this issue.
> >
> > Signed-off-by: Erik Botö <erik.boto@pelagicore.com>
> > ---
> >   meta/lib/oeqa/controllers/masterimage.py | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/lib/oeqa/controllers/masterimage.py b/meta/lib/oeqa/controllers/masterimage.py
> > index 07418fcda1..6cdcfa3068 100644
> > --- a/meta/lib/oeqa/controllers/masterimage.py
> > +++ b/meta/lib/oeqa/controllers/masterimage.py
> > @@ -108,7 +108,7 @@ class MasterImageHardwareTarget(oeqa.targetcontrol.BaseTarget, metaclass=ABCMeta
> >               time.sleep(10)
> >               self.power_ctl("cycle")
> >           else:
> > -            status, output = conn.run("reboot")
> > +            status, output = conn.run("{ sleep 1; reboot; } > /dev/null &")
> >               if status != 0:
> >                   bb.error("Failed rebooting target and no power control command defined. You need to manually reset the device.\n%s" % output)
> >   
> 




  reply	other threads:[~2017-05-26 13:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19 14:20 [PATCH 1/4] masterimage.py: fix issue with calling reboot on masterimage/DUT Erik Botö
2017-05-19 14:20 ` [PATCH 2/4] masterimage.py: rename parameter "params" in start() to "extra_bootparams" Erik Botö
2017-05-19 14:20 ` [PATCH 3/4] masterimage.py: fix stop() Erik Botö
2017-05-19 14:20 ` [PATCH 4/4] sshcontrol.py: in copy_to() always use scp Erik Botö
2017-05-19 14:59 ` [PATCH 1/4] masterimage.py: fix issue with calling reboot on masterimage/DUT Leonardo Sandoval
2017-05-19 18:24   ` Erik Botö
2017-05-26  9:01 ` Erik Botö
2017-05-26 13:57   ` Leonardo Sandoval [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-11-06 18:13 [PATCH 0/4] fix runtime tests with systemd-boot Stephano Cetola
2017-11-06 18:13 ` [PATCH 1/4] masterimage.py: fix issue with calling reboot on masterimage/DUT Stephano Cetola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495807047.26945.19.camel@linux.intel.com \
    --to=leonardo.sandoval.gonzalez@linux.intel.com \
    --cc=erik.boto@pelagicore.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=stephano.cetola@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox