Re: [PATCH 1/2] devshell.bbclass: ensure toolchains available for do_devshell

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2017-05-30 at 12:07 +1200, Paul Eggleton wrote:
> Hi Richard,
> 
> On Tuesday, 30 May 2017 11:31:36 AM NZST Richard Purdie wrote:
> > 
> > On Mon, 2017-05-29 at 13:16 +0800, Chang Rebecca Swee Fun wrote:
> > > 
> > > Toolchains are required to be prepopulated in sysroot before
> > > entering devshell.
> > > 
> > > [YOCTO #11464]
> > > 
> > > Signed-off-by: Chang Rebecca Swee Fun 
> > > ---
> > >  meta/classes/devshell.bbclass | 11 ++++++++++-
> > >  1 file changed, 10 insertions(+), 1 deletion(-)
> > This looks awfully complicated and I'm not sure this does much more
> > than this would:
> > 
> > -addtask devshell after do_patch
> > +addtask devshell after do_prepare_recipe_sysroot
> > 
> > Can someone explain to me why we want to do the below instead as I
> > think the effect is the same?
> > 
> > I did read the bug too but that didn't help answer my question.
> > 
> > Yes, this does mean devshell will now trigger a lot of more
> > dependencies and build but I think the change below would do the
> > same
> > thing too.
> I'd suggested the method Rebecca is using in the bug, but you're
> right, I'm 
> not sure why I didn't think of doing as you suggest instead.
> Presumably 
> however since do_prepare_recipe_sysroot doesn't depend on do_patch we
> would 
> still need to depend on that i.e.:
> 
> addtask devshell after do_patch do_prepare_recipe_sysroot
> 
> Right?

Yes, you're right that we still need do_patch too.

Cheers,

Richard