Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Trevor Woerner <twoerner@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] mesa: potentially enable texture float for gallium
Date: Tue, 30 May 2017 17:19:09 +0100	[thread overview]
Message-ID: <1496161149.6630.14.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAHUNapR0bPQq4qJnzK-ddPzn-m-0FCtVYLDBMsBuLY=eJUgmZg@mail.gmail.com>

On Tue, 2017-05-30 at 12:00 -0400, Trevor Woerner wrote:
> On Tue, May 30, 2017 at 11:44 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > 
> > > 
> > > Maybe this would be a better way forward? Enable it, always, in
> > > ./configure,
> > > add the patch to check for it in the code itself, then you can
> > > build
> > > for all
> > > the gallium targets (including swrast) and know that the patented
> > > code will
> > > only kick in where it's supported in hardware (and thus patent-
> > > safe)?
> > That sounds like exactly what we need to do!
> Okay. The only caveat being, if someone actually *wanted* to enable
> float for swrast, this would prevent them from going down that path.
> 
> ajax on #dri-devel pointed out that some piglit tests go from pass to
> fail instead of being skipped as a result of the above patch since
> the
> piglit tests are done with swrast and run very poorly without float
> enabled.

If someone really wants to enable it, they can drop the patch. I'm open
to feedback from others like Ross/Jussi but IMO I think we can accept
the degraded piglit results for swrast...

Cheers,

Richard


  reply	other threads:[~2017-05-30 16:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26 21:22 [PATCH] mesa: potentially enable texture float for gallium Trevor Woerner
2017-05-29 23:25 ` Richard Purdie
2017-05-30  5:28   ` Trevor Woerner
2017-05-30  7:47     ` Richard Purdie
2017-05-30 15:27       ` Trevor Woerner
2017-05-30 15:44         ` Richard Purdie
2017-05-30 16:00           ` Trevor Woerner
2017-05-30 16:19             ` Richard Purdie [this message]
2017-05-31  7:15               ` Jussi Kukkonen
2017-05-31 16:03                 ` Trevor Woerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496161149.6630.14.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=twoerner@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox