Re: [PATCH v2] python3: make readline, gdbm, and db support conditional.

["Puustinen, Ismo" <ismo.puustinen@intel.com>]

On Wed, 2017-06-07 at 15:10 +0100, Burton, Ross wrote:
> 
> On 7 June 2017 at 14:49, Ismo Puustinen <ismo.puustinen@intel.com>
> wrote:
> > +RRECOMMENDS_${PN}-core = "${@bb.utils.contains('PACKAGECONFIG',
> > 'readline', '${PN}-readline', '', d)}"
> > 
> 
> Recommends can not exists, so I wouldn't bother with this
> complication.

Ok, I'll remove it.

> > +RDEPENDS_${PN}-modules_remove += "${@bb.utils.contains('PACKAGECON
> > FIG', 'readline', '', '${PN}-readline', d)}"
> 
> (etc)
> 
> Don't use _remove and += as it's confusing.

I'll change that.

> But if for example readline is disabled, why would the package be
> created in the first place?

The package indeed isn't created. However, it's added to
RDEPENDS_python3-modules in python3 manifest file here:

https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devto
ols/python/python-3.5-manifest.inc#n280

The other variable changes are done also in the manifest. However, the
manifest file warns about modifying it, so the patch "reverses" the
changes based on PACKAGECONFIG from the recipe.

Ismo